Skip to content

Commit

Permalink
merge_config.sh: Avoid creating unnessary source softlinks
Browse files Browse the repository at this point in the history
Viresh noticed when using merge_config.sh that a source softlink
was being created even when he didn't specify the -O option.

The problem arises due to the previous commit 409f117
which added the -O option. Basically if -O is not specified,
we still pass '-O=.' to the make command, which then generates
a source softlink to ./

This patch adds an extra check so if there is no -O specified
to merge_config.sh, we don't pass one on to make.

Cc: Zhangfei Gao <[email protected]>
Cc: Bruce Ashfield <[email protected]>
Acked-by: Darren Hart <[email protected]>
Reported-and-tested-by: Viresh Kumar <[email protected]>
Signed-off-by: John Stultz <[email protected]>
Signed-off-by: Michal Marek <[email protected]>
  • Loading branch information
johnstultz-work authored and michal42 committed Apr 10, 2013
1 parent 0f40d9d commit a45c7df
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion scripts/kconfig/merge_config.sh
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,18 @@ if [ "$MAKE" = "false" ]; then
exit
fi

# If we have an output dir, setup the O= argument, otherwise leave
# it blank, since O=. will create an unnecessary ./source softlink
OUTPUT_ARG=""
if [ "$OUTPUT" != "." ] ; then
OUTPUT_ARG="O=$OUTPUT"
fi


# Use the merged file as the starting point for:
# alldefconfig: Fills in any missing symbols with Kconfig default
# allnoconfig: Fills in any missing symbols with # CONFIG_* is not set
make KCONFIG_ALLCONFIG=$TMP_FILE O=$OUTPUT $ALLTARGET
make KCONFIG_ALLCONFIG=$TMP_FILE $OUTPUT_ARG $ALLTARGET


# Check all specified config values took (might have missed-dependency issues)
Expand Down

0 comments on commit a45c7df

Please sign in to comment.