Skip to content

Commit

Permalink
packet: restore packet statistics tp_packets to include drops
Browse files Browse the repository at this point in the history
getsockopt PACKET_STATISTICS returns tp_packets + tp_drops. Commit
ee80fbf ("packet: account statistics only in tpacket_stats_u")
cleaned up the getsockopt PACKET_STATISTICS code.
This also changed semantics. Historically, tp_packets included
tp_drops on return. The commit removed the line that adds tp_drops
into tp_packets.

This patch reinstates the old semantics.

Signed-off-by: Willem de Bruijn <[email protected]>
Acked-by: Daniel Borkmann <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
wdebruij authored and davem330 committed Aug 21, 2013
1 parent 8b64fd6 commit 8bcdeaf
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions net/packet/af_packet.c
Original file line number Diff line number Diff line change
Expand Up @@ -3259,9 +3259,11 @@ static int packet_getsockopt(struct socket *sock, int level, int optname,

if (po->tp_version == TPACKET_V3) {
lv = sizeof(struct tpacket_stats_v3);
st.stats3.tp_packets += st.stats3.tp_drops;
data = &st.stats3;
} else {
lv = sizeof(struct tpacket_stats);
st.stats1.tp_packets += st.stats1.tp_drops;
data = &st.stats1;
}

Expand Down

0 comments on commit 8bcdeaf

Please sign in to comment.