Skip to content

Commit

Permalink
device create: misc: convert device_create to device_create_drvdata
Browse files Browse the repository at this point in the history
device_create() is race-prone, so use the race-free
device_create_drvdata() instead as device_create() is going away.

Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
gregkh committed Jul 22, 2008
1 parent 43f9874 commit 7da5a05
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/misc/phantom.c
Original file line number Diff line number Diff line change
Expand Up @@ -399,8 +399,9 @@ static int __devinit phantom_probe(struct pci_dev *pdev,
goto err_irq;
}

if (IS_ERR(device_create(phantom_class, &pdev->dev, MKDEV(phantom_major,
minor), "phantom%u", minor)))
if (IS_ERR(device_create_drvdata(phantom_class, &pdev->dev,
MKDEV(phantom_major, minor),
NULL, "phantom%u", minor)))
dev_err(&pdev->dev, "can't create device\n");

pci_set_drvdata(pdev, pht);
Expand Down

0 comments on commit 7da5a05

Please sign in to comment.