Skip to content

Commit

Permalink
rtc: rtc-pcf8583: use dev_warn() instead of printk()
Browse files Browse the repository at this point in the history
Fix the checkpatch warning as below:

  WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Signed-off-by: Jingoo Han <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Jingoo Han authored and torvalds committed Feb 22, 2013
1 parent d959f73 commit 79d1340
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/rtc/rtc-pcf8583.c
Original file line number Diff line number Diff line change
Expand Up @@ -185,8 +185,8 @@ static int pcf8583_rtc_read_time(struct device *dev, struct rtc_time *tm)
if (ctrl & (CTRL_STOP | CTRL_HOLD)) {
unsigned char new_ctrl = ctrl & ~(CTRL_STOP | CTRL_HOLD);

printk(KERN_WARNING "RTC: resetting control %02x -> %02x\n",
ctrl, new_ctrl);
dev_warn(dev, "resetting control %02x -> %02x\n",
ctrl, new_ctrl);

if ((err = pcf8583_set_ctrl(client, &new_ctrl)) < 0)
return err;
Expand Down

0 comments on commit 79d1340

Please sign in to comment.