[XFS] Fix char size overflow in bmap_alloc call for unwritten extent

conversion. Since bma.conv is a char and XFS_BMAPI_CONVERT is 0x1000, bma.conv was always assigned zero. Spotted by the GNU C compiler (SVN version). SGI-PV: 947312 SGI-Modid: xfs-linux-melb:xfs-kern:26887a Signed-off-by: Adrian Bunk <[email protected]> Signed-off-by: Nathan Scott <[email protected]>
kishon · Aug 30, 2006 · 7288026 · 7288026
1 parent 1ad8f40
commit 7288026
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/fs/xfs/xfs_bmap.c b/fs/xfs/xfs_bmap.c
@@ -4993,7 +4993,7 @@ xfs_bmapi(
 				bma.firstblock = *firstblock;
 				bma.alen = alen;
 				bma.off = aoff;
-				bma.conv = (flags & XFS_BMAPI_CONVERT);
+				bma.conv = !!(flags & XFS_BMAPI_CONVERT);
 				bma.wasdel = wasdelay;
 				bma.minlen = minlen;
 				bma.low = flist->xbf_low;