WAN: bit and/or confusion

Fix the tests that check whether Frame* bits are not set Signed-off-by: Roel Kluin <[email protected]> Signed-off-by: David S. Miller <[email protected]>
kishon · Aug 31, 2009 · 5de3fca · 5de3fca
1 parent 2394905
commit 5de3fca
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/drivers/net/wan/dscc4.c b/drivers/net/wan/dscc4.c
@@ -663,12 +663,12 @@ static inline void dscc4_rx_skb(struct dscc4_dev_priv *dpriv,
 	} else {
 		if (skb->data[pkt_len] & FrameRdo)
 			dev->stats.rx_fifo_errors++;
-		else if (!(skb->data[pkt_len] | ~FrameCrc))
+		else if (!(skb->data[pkt_len] & FrameCrc))
 			dev->stats.rx_crc_errors++;
-		else if (!(skb->data[pkt_len] | ~(FrameVfr | FrameRab)))
+		else if ((skb->data[pkt_len] & (FrameVfr | FrameRab)) !=
+				FrameVfr | FrameRab)
 			dev->stats.rx_length_errors++;
-		else
-			dev->stats.rx_errors++;
+		dev->stats.rx_errors++;
 		dev_kfree_skb_irq(skb);
 	}
 refill: