Skip to content

Commit

Permalink
[NET]: div64_64 consolidate (rev3)
Browse files Browse the repository at this point in the history
Here is the current version of the 64 bit divide common code.

Signed-off-by: Stephen Hemminger <[email protected]>
Signed-off-by: David S. Miller <[email protected]>
  • Loading branch information
Stephen Hemminger authored and David S. Miller committed Apr 26, 2007
1 parent 9d729f7 commit 3927f2e
Show file tree
Hide file tree
Showing 13 changed files with 60 additions and 63 deletions.
3 changes: 3 additions & 0 deletions include/asm-arm/div64.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#define __ASM_ARM_DIV64

#include <asm/system.h>
#include <linux/types.h>

/*
* The semantics of do_div() are:
Expand Down Expand Up @@ -223,4 +224,6 @@

#endif

extern uint64_t div64_64(uint64_t dividend, uint64_t divisor);

#endif
7 changes: 7 additions & 0 deletions include/asm-generic/div64.h
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@
__rem; \
})

static inline uint64_t div64_64(uint64_t dividend, uint64_t divisor)
{
return dividend / divisor;
}

#elif BITS_PER_LONG == 32

extern uint32_t __div64_32(uint64_t *dividend, uint32_t divisor);
Expand All @@ -49,6 +54,8 @@ extern uint32_t __div64_32(uint64_t *dividend, uint32_t divisor);
__rem; \
})

extern uint64_t div64_64(uint64_t dividend, uint64_t divisor);

#else /* BITS_PER_LONG == ?? */

# error do_div() does not yet support the C64
Expand Down
4 changes: 4 additions & 0 deletions include/asm-i386/div64.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#ifndef __I386_DIV64
#define __I386_DIV64

#include <linux/types.h>

/*
* do_div() is NOT a C function. It wants to return
* two values (the quotient and the remainder), but
Expand Down Expand Up @@ -45,4 +47,6 @@ div_ll_X_l_rem(long long divs, long div, long *rem)
return dum2;

}

extern uint64_t div64_64(uint64_t dividend, uint64_t divisor);
#endif
3 changes: 3 additions & 0 deletions include/asm-m68k/div64.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
#ifndef _M68K_DIV64_H
#define _M68K_DIV64_H

#include <linux/types.h>

/* n = n / base; return rem; */

#define do_div(n, base) ({ \
Expand All @@ -23,4 +25,5 @@
__rem; \
})

extern uint64_t div64_64(uint64_t dividend, uint64_t divisor);
#endif /* _M68K_DIV64_H */
11 changes: 10 additions & 1 deletion include/asm-mips/div64.h
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
/*
* Copyright (C) 2000, 2004 Maciej W. Rozycki
* Copyright (C) 2003 Ralf Baechle
* Copyright (C) 2003, 07 Ralf Baechle ([email protected])
*
* This file is subject to the terms and conditions of the GNU General Public
* License. See the file "COPYING" in the main directory of this archive
Expand All @@ -9,6 +9,8 @@
#ifndef _ASM_DIV64_H
#define _ASM_DIV64_H

#include <linux/types.h>

#if (_MIPS_SZLONG == 32)

#include <asm/compiler.h>
Expand Down Expand Up @@ -78,6 +80,8 @@
__quot = __quot << 32 | __low; \
(n) = __quot; \
__mod; })

extern uint64_t div64_64(uint64_t dividend, uint64_t divisor);
#endif /* (_MIPS_SZLONG == 32) */

#if (_MIPS_SZLONG == 64)
Expand All @@ -101,6 +105,11 @@
(n) = __quot; \
__mod; })

static inline uint64_t div64_64(uint64_t dividend, uint64_t divisor)
{
return dividend / divisor;
}

#endif /* (_MIPS_SZLONG == 64) */

#endif /* _ASM_DIV64_H */
1 change: 1 addition & 0 deletions include/asm-um/div64.h
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@

#include "asm/arch/div64.h"

extern uint64_t div64_64(uint64_t dividend, uint64_t divisor);
#endif
6 changes: 6 additions & 0 deletions include/asm-xtensa/div64.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,15 @@
#ifndef _XTENSA_DIV64_H
#define _XTENSA_DIV64_H

#include <linux/types.h>

#define do_div(n,base) ({ \
int __res = n % ((unsigned int) base); \
n /= (unsigned int) base; \
__res; })

static inline uint64_t div64_64(uint64_t dividend, uint64_t divisor)
{
return dividend / divisor;
}
#endif
5 changes: 3 additions & 2 deletions lib/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -4,15 +4,16 @@

lib-y := ctype.o string.o vsprintf.o cmdline.o \
rbtree.o radix-tree.o dump_stack.o \
idr.o div64.o int_sqrt.o bitmap.o extable.o prio_tree.o \
idr.o int_sqrt.o bitmap.o extable.o prio_tree.o \
sha1.o irq_regs.o reciprocal_div.o

lib-$(CONFIG_MMU) += ioremap.o
lib-$(CONFIG_SMP) += cpumask.o

lib-y += kobject.o kref.o kobject_uevent.o klist.o

obj-y += sort.o parser.o halfmd4.o debug_locks.o random32.o bust_spinlocks.o
obj-y += div64.o sort.o parser.o halfmd4.o debug_locks.o random32.o \
bust_spinlocks.o

ifeq ($(CONFIG_DEBUG_KOBJECT),y)
CFLAGS_kobject.o += -DDEBUG
Expand Down
22 changes: 22 additions & 0 deletions lib/div64.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,4 +58,26 @@ uint32_t __div64_32(uint64_t *n, uint32_t base)

EXPORT_SYMBOL(__div64_32);

/* 64bit divisor, dividend and result. dynamic precision */
uint64_t div64_64(uint64_t dividend, uint64_t divisor)
{
uint32_t d = divisor;

if (divisor > 0xffffffffULL) {
unsigned int shift = fls(divisor >> 32);

d = divisor >> shift;
dividend >>= shift;
}

/* avoid 64 bit division if possible */
if (dividend >> 32)
do_div(dividend, d);
else
dividend = (uint32_t) dividend / d;

return dividend;
}
EXPORT_SYMBOL(div64_64);

#endif /* BITS_PER_LONG == 32 */
23 changes: 0 additions & 23 deletions net/ipv4/tcp_cubic.c
Original file line number Diff line number Diff line change
Expand Up @@ -51,8 +51,6 @@ MODULE_PARM_DESC(bic_scale, "scale (scaled by 1024) value for bic function (bic_
module_param(tcp_friendliness, int, 0644);
MODULE_PARM_DESC(tcp_friendliness, "turn on/off tcp friendliness");

#include <asm/div64.h>

/* BIC TCP Parameters */
struct bictcp {
u32 cnt; /* increase cwnd by 1 after ACKs */
Expand Down Expand Up @@ -93,27 +91,6 @@ static void bictcp_init(struct sock *sk)
tcp_sk(sk)->snd_ssthresh = initial_ssthresh;
}

/* 64bit divisor, dividend and result. dynamic precision */
static inline u_int64_t div64_64(u_int64_t dividend, u_int64_t divisor)
{
u_int32_t d = divisor;

if (divisor > 0xffffffffULL) {
unsigned int shift = fls(divisor >> 32);

d = divisor >> shift;
dividend >>= shift;
}

/* avoid 64 bit division if possible */
if (dividend >> 32)
do_div(dividend, d);
else
dividend = (uint32_t) dividend / d;

return dividend;
}

/*
* calculate the cubic root of x using Newton-Raphson
*/
Expand Down
21 changes: 0 additions & 21 deletions net/ipv4/tcp_yeah.c
Original file line number Diff line number Diff line change
Expand Up @@ -73,27 +73,6 @@ static void tcp_yeah_pkts_acked(struct sock *sk, u32 pkts_acked)
yeah->pkts_acked = pkts_acked;
}

/* 64bit divisor, dividend and result. dynamic precision */
static inline u64 div64_64(u64 dividend, u64 divisor)
{
u32 d = divisor;

if (divisor > 0xffffffffULL) {
unsigned int shift = fls(divisor >> 32);

d = divisor >> shift;
dividend >>= shift;
}

/* avoid 64 bit division if possible */
if (dividend >> 32)
do_div(dividend, d);
else
dividend = (u32) dividend / d;

return dividend;
}

static void tcp_yeah_cong_avoid(struct sock *sk, u32 ack,
u32 seq_rtt, u32 in_flight, int flag)
{
Expand Down
1 change: 1 addition & 0 deletions net/ipv4/tcp_yeah.h
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
#include <linux/module.h>
#include <linux/skbuff.h>
#include <linux/inet_diag.h>
#include <asm/div64.h>

#include <net/tcp.h>

Expand Down
16 changes: 0 additions & 16 deletions net/netfilter/xt_connbytes.c
Original file line number Diff line number Diff line change
Expand Up @@ -24,22 +24,6 @@ MODULE_AUTHOR("Harald Welte <[email protected]>");
MODULE_DESCRIPTION("iptables match for matching number of pkts/bytes per connection");
MODULE_ALIAS("ipt_connbytes");

/* 64bit divisor, dividend and result. dynamic precision */
static u_int64_t div64_64(u_int64_t dividend, u_int64_t divisor)
{
u_int32_t d = divisor;

if (divisor > 0xffffffffULL) {
unsigned int shift = fls(divisor >> 32);

d = divisor >> shift;
dividend >>= shift;
}

do_div(dividend, d);
return dividend;
}

static int
match(const struct sk_buff *skb,
const struct net_device *in,
Expand Down

0 comments on commit 3927f2e

Please sign in to comment.