Skip to content

Commit

Permalink
unicore32 i8042: adjust io funcs of i8042-unicore32io.h
Browse files Browse the repository at this point in the history
replace inb/outb with readb/writeb in i8042-unicore32io.h
and correct typecasting of register and region macros
  -- by advice with Arnd Bergmann

Signed-off-by: Guan Xuetao <[email protected]>
  • Loading branch information
gxt committed Mar 17, 2011
1 parent bd42aa7 commit 3838b82
Showing 1 changed file with 12 additions and 9 deletions.
21 changes: 12 additions & 9 deletions drivers/input/serio/i8042-unicore32io.h
Original file line number Diff line number Diff line change
Expand Up @@ -29,33 +29,36 @@
/*
* Register numbers.
*/
#define I8042_COMMAND_REG ((unsigned long)&PS2_COMMAND)
#define I8042_STATUS_REG ((unsigned long)&PS2_STATUS)
#define I8042_DATA_REG ((unsigned long)&PS2_DATA)
#define I8042_COMMAND_REG ((volatile void __iomem *)&PS2_COMMAND)
#define I8042_STATUS_REG ((volatile void __iomem *)&PS2_STATUS)
#define I8042_DATA_REG ((volatile void __iomem *)&PS2_DATA)

#define I8042_REGION_START (resource_size_t)(&PS2_DATA)
#define I8042_REGION_SIZE (resource_size_t)(16)

static inline int i8042_read_data(void)
{
return inb(I8042_DATA_REG);
return readb(I8042_DATA_REG);
}

static inline int i8042_read_status(void)
{
return inb(I8042_STATUS_REG);
return readb(I8042_STATUS_REG);
}

static inline void i8042_write_data(int val)
{
outb(val, I8042_DATA_REG);
writeb(val, I8042_DATA_REG);
}

static inline void i8042_write_command(int val)
{
outb(val, I8042_COMMAND_REG);
writeb(val, I8042_COMMAND_REG);
}

static inline int i8042_platform_init(void)
{
if (!request_region(I8042_DATA_REG, 16, "i8042"))
if (!request_region(I8042_REGION_START, I8042_REGION_SIZE, "i8042"))
return -EBUSY;

i8042_reset = 1;
Expand All @@ -64,7 +67,7 @@ static inline int i8042_platform_init(void)

static inline void i8042_platform_exit(void)
{
release_region(I8042_DATA_REG, 16);
release_region(I8042_REGION_START, I8042_REGION_SIZE);
}

#endif /* _I8042_UNICORE32_H */

0 comments on commit 3838b82

Please sign in to comment.