Skip to content

Commit

Permalink
device create: dca: convert device_create to device_create_drvdata
Browse files Browse the repository at this point in the history
device_create() is race-prone, so use the race-free
device_create_drvdata() instead as device_create() is going away.

Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
gregkh committed Jul 22, 2008
1 parent 6143b59 commit 275e64d
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions drivers/dca/dca-sysfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,9 @@ int dca_sysfs_add_req(struct dca_provider *dca, struct device *dev, int slot)
{
struct device *cd;

cd = device_create(dca_class, dca->cd, MKDEV(0, slot + 1),
"requester%d", slot);
cd = device_create_drvdata(dca_class, dca->cd,
MKDEV(0, slot + 1), NULL,
"requester%d", slot);
if (IS_ERR(cd))
return PTR_ERR(cd);
return 0;
Expand Down Expand Up @@ -46,7 +47,8 @@ int dca_sysfs_add_provider(struct dca_provider *dca, struct device *dev)
return err;
}

cd = device_create(dca_class, dev, MKDEV(0, 0), "dca%d", dca->id);
cd = device_create_drvdata(dca_class, dev, MKDEV(0, 0), NULL,
"dca%d", dca->id);
if (IS_ERR(cd)) {
spin_lock(&dca_idr_lock);
idr_remove(&dca_idr, dca->id);
Expand Down

0 comments on commit 275e64d

Please sign in to comment.