Skip to content

Commit

Permalink
isofs check for NULL ->i_op in root directory is dead code
Browse files Browse the repository at this point in the history
for one thing it never happens, for another we check that inode
is a directory right after that place anyway (and we'd already
checked that reading it from disk has not failed).

Signed-off-by: Al Viro <[email protected]>
  • Loading branch information
Al Viro committed Jan 5, 2009
1 parent c765d47 commit 261964c
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions fs/isofs/inode.c
Original file line number Diff line number Diff line change
Expand Up @@ -855,10 +855,6 @@ static int isofs_fill_super(struct super_block *s, void *data, int silent)
}
sbi->s_joliet_level = joliet_level;

/* check the root inode */
if (!inode->i_op)
goto out_bad_root;

/* Make sure the root inode is a directory */
if (!S_ISDIR(inode->i_mode)) {
printk(KERN_WARNING
Expand Down Expand Up @@ -886,8 +882,6 @@ static int isofs_fill_super(struct super_block *s, void *data, int silent)
/*
* Display error messages and free resources.
*/
out_bad_root:
printk(KERN_WARNING "%s: root inode not initialized\n", __func__);
out_iput:
iput(inode);
goto out_no_inode;
Expand Down

0 comments on commit 261964c

Please sign in to comment.