Skip to content

Commit

Permalink
platform-drivers: move probe to .devinit.text in drivers/scsi
Browse files Browse the repository at this point in the history
A pointer to a probe callback is passed to the core via
platform_driver_register and so the function must not disappear when the
.init sections are discarded.  Otherwise (if also having HOTPLUG=y)
unbinding and binding a device to the driver via sysfs will result in an
oops as does a device being registered late.

An alternative to this patch is using platform_driver_probe instead of
platform_driver_register plus removing the pointer to the probe function
from the struct platform_driver.

Signed-off-by: Uwe Kleine-König <[email protected]>
Cc: Andrew Morton <[email protected]>
Cc: David Brownell <[email protected]>
Cc: Dmitri Vorobiev <[email protected]>
Cc: Henrik Kretzschmar <[email protected]>
Cc: James Bottomley <[email protected]>
Cc: Kay Sievers <[email protected]>
Cc: peter fuerst <[email protected]>
Cc: Thomas Bogendoerfer <[email protected]>
Acked-by: Ralf Baechle <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
Uwe Kleine-König authored and gregkh committed Mar 8, 2010
1 parent 91a99df commit 1b07193
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/scsi/sgiwd93.c
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,7 @@ static struct scsi_host_template sgiwd93_template = {
.use_clustering = DISABLE_CLUSTERING,
};

static int __init sgiwd93_probe(struct platform_device *pdev)
static int __devinit sgiwd93_probe(struct platform_device *pdev)
{
struct sgiwd93_platform_data *pd = pdev->dev.platform_data;
unsigned char *wdregs = pd->wdregs;
Expand Down
2 changes: 1 addition & 1 deletion drivers/scsi/sni_53c710.c
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ static struct scsi_host_template snirm710_template = {
.module = THIS_MODULE,
};

static int __init snirm710_probe(struct platform_device *dev)
static int __devinit snirm710_probe(struct platform_device *dev)
{
unsigned long base;
struct NCR_700_Host_Parameters *hostdata;
Expand Down

0 comments on commit 1b07193

Please sign in to comment.