Skip to content

Commit

Permalink
x86, bitops: select the generic bitmap search functions
Browse files Browse the repository at this point in the history
Introduce GENERIC_FIND_FIRST_BIT and GENERIC_FIND_NEXT_BIT in
lib/Kconfig, defaulting to off. An arch that wants to use the
generic implementation now only has to use a select statement
to include them.

I added an always-y option (X86_CPU) to arch/x86/Kconfig.cpu
and used that to select the generic search functions. This
way ARCH=um SUBARCH=i386 automatically picks up the change
too, and arch/um/Kconfig.i386 can therefore be simplified a
bit. ARCH=um SUBARCH=x86_64 does things differently, but
still compiles fine. It seems that a "def_bool y" always
wins over a "def_bool n"?

Signed-off-by: Alexander van Heukelum <[email protected]>
Signed-off-by: Ingo Molnar <[email protected]>
  • Loading branch information
Alexander van Heukelum authored and Ingo Molnar committed Apr 26, 2008
1 parent f19dcf4 commit 19870de
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 22 deletions.
8 changes: 0 additions & 8 deletions arch/um/Kconfig.i386
Original file line number Diff line number Diff line change
Expand Up @@ -39,14 +39,6 @@ config ARCH_REUSE_HOST_VSYSCALL_AREA
bool
default y

config GENERIC_FIND_FIRST_BIT
bool
default y

config GENERIC_FIND_NEXT_BIT
bool
default y

config GENERIC_HWEIGHT
bool
default y
Expand Down
8 changes: 0 additions & 8 deletions arch/um/Kconfig.x86_64
Original file line number Diff line number Diff line change
Expand Up @@ -34,14 +34,6 @@ config SMP_BROKEN
bool
default y

config GENERIC_FIND_FIRST_BIT
bool
default y

config GENERIC_FIND_NEXT_BIT
bool
default y

config GENERIC_HWEIGHT
bool
default y
Expand Down
6 changes: 0 additions & 6 deletions arch/x86/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,6 @@ config GENERIC_BUG
def_bool y
depends on BUG

config GENERIC_FIND_FIRST_BIT
def_bool y

config GENERIC_FIND_NEXT_BIT
def_bool y

config GENERIC_HWEIGHT
def_bool y

Expand Down
5 changes: 5 additions & 0 deletions arch/x86/Kconfig.cpu
Original file line number Diff line number Diff line change
Expand Up @@ -278,6 +278,11 @@ config GENERIC_CPU

endchoice

config X86_CPU
def_bool y
select GENERIC_FIND_FIRST_BIT
select GENERIC_FIND_NEXT_BIT

config X86_GENERIC
bool "Generic x86 support"
depends on X86_32
Expand Down
6 changes: 6 additions & 0 deletions lib/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ menu "Library routines"
config BITREVERSE
tristate

config GENERIC_FIND_FIRST_BIT
def_bool n

config GENERIC_FIND_NEXT_BIT
def_bool n

config CRC_CCITT
tristate "CRC-CCITT functions"
help
Expand Down

0 comments on commit 19870de

Please sign in to comment.