Skip to content

Commit

Permalink
VIDEO: Correct use of request_region/request_mem_region
Browse files Browse the repository at this point in the history
request_region should be used with release_region, not request_mem_region.

Geert Uytterhoeven pointed out that in the case of drivers/video/gbefb.c,
the problem is actually the other way around; request_mem_region should be
used instead of request_region.

The semantic patch that finds/fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@r1@
expression start;
@@

request_region(start,...)

@b1@
expression r1.start;
@@

request_mem_region(start,...)

@Depends on !b1@
expression r1.start;
expression E;
@@

- release_mem_region
+ release_region
  (start,E)
// </smpl>

Signed-off-by: Julia Lawall <[email protected]>
Signed-off-by: Ralf Baechle <[email protected]>
  • Loading branch information
Julia Lawall authored and ralfbaechle committed Dec 2, 2009
1 parent dbf763a commit 0fdd07f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/video/gbefb.c
Original file line number Diff line number Diff line change
Expand Up @@ -1147,7 +1147,7 @@ static int __init gbefb_probe(struct platform_device *p_dev)
gbefb_setup(options);
#endif

if (!request_region(GBE_BASE, sizeof(struct sgi_gbe), "GBE")) {
if (!request_mem_region(GBE_BASE, sizeof(struct sgi_gbe), "GBE")) {
printk(KERN_ERR "gbefb: couldn't reserve mmio region\n");
ret = -EBUSY;
goto out_release_framebuffer;
Expand Down

0 comments on commit 0fdd07f

Please sign in to comment.