Skip to content

Commit

Permalink
crypto: testmgr - Default to no tests
Browse files Browse the repository at this point in the history
On Thu, Aug 05, 2010 at 07:01:21PM -0700, Linus Torvalds wrote:
> On Thu, Aug 5, 2010 at 6:40 PM, Herbert Xu <[email protected]> wrote:
> >
> > -config CRYPTO_MANAGER_TESTS
> > -       bool "Run algolithms' self-tests"
> > -       default y
> > -       depends on CRYPTO_MANAGER2
> > +config CRYPTO_MANAGER_DISABLE_TESTS
> > +       bool "Disable run-time self tests"
> > +       depends on CRYPTO_MANAGER2 && EMBEDDED
>
> Why do you still want to force-enable those tests? I was going to
> complain about the "default y" anyway, now I'm _really_ complaining,
> because you've now made it impossible to disable those tests. Why?

As requested, this patch sets the default to y and removes the
EMBEDDED dependency.

Signed-off-by: Herbert Xu <[email protected]>
  • Loading branch information
herbertx committed Aug 6, 2010
1 parent 326a634 commit 00ca28a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion crypto/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,8 @@ config CRYPTO_MANAGER2

config CRYPTO_MANAGER_DISABLE_TESTS
bool "Disable run-time self tests"
depends on CRYPTO_MANAGER2 && EMBEDDED
default y
depends on CRYPTO_MANAGER2
help
Disable run-time self tests that normally take place at
algorithm registration.
Expand Down

0 comments on commit 00ca28a

Please sign in to comment.