Skip to content

Commit

Permalink
Minor improvements to tmdb code
Browse files Browse the repository at this point in the history
  • Loading branch information
@Bond-009
Bond-009 committed Oct 6, 2020
1 parent 3a238de commit 6def4b0
Show file tree
Hide file tree
Showing 5 changed files with 60 additions and 52 deletions.
14 changes: 7 additions & 7 deletions MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbEpisodeImageProvider.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,17 +67,17 @@ public async Task<IEnumerable<RemoteImageInfo>> GetImages(BaseItem item, Cancell
.GetEpisodeAsync(seriesTmdbId, seasonNumber.Value, episodeNumber.Value, language, TmdbUtils.GetImageLanguagesParam(language), cancellationToken)
.ConfigureAwait(false);

if (episodeResult?.Images?.Stills == null)
var stills = episodeResult?.Images?.Stills;
if (stills == null)
{
return Enumerable.Empty<RemoteImageInfo>();
}

var remoteImages = new List<RemoteImageInfo>();

for (var i = 0; i < episodeResult.Images.Stills.Count; i++)
var remoteImages = new RemoteImageInfo[stills.Count];
for (var i = 0; i < stills.Count; i++)
{
var image = episodeResult.Images.Stills[i];
remoteImages.Add(new RemoteImageInfo
var image = stills[i];
remoteImages[i] = new RemoteImageInfo
{
Url = _tmdbClientManager.GetStillUrl(image.FilePath),
CommunityRating = image.VoteAverage,
Expand All @@ -88,7 +88,7 @@ public async Task<IEnumerable<RemoteImageInfo>> GetImages(BaseItem item, Cancell
ProviderName = Name,
Type = ImageType.Primary,
RatingType = RatingType.Score
});
};
}

return remoteImages.OrderByLanguageDescending(language);
Expand Down
32 changes: 15 additions & 17 deletions MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbEpisodeProvider.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -40,30 +40,29 @@ public async Task<IEnumerable<RemoteSearchResult>> GetSearchResults(EpisodeInfo
return Enumerable.Empty<RemoteSearchResult>();
}

var metadataResult = await GetMetadata(searchInfo, cancellationToken);
var metadataResult = await GetMetadata(searchInfo, cancellationToken).ConfigureAwait(false);

if (!metadataResult.HasMetadata)
{
return Enumerable.Empty<RemoteSearchResult>();
}

var list = new List<RemoteSearchResult>();

var item = metadataResult.Item;

list.Add(new RemoteSearchResult
return new[]
{
IndexNumber = item.IndexNumber,
Name = item.Name,
ParentIndexNumber = item.ParentIndexNumber,
PremiereDate = item.PremiereDate,
ProductionYear = item.ProductionYear,
ProviderIds = item.ProviderIds,
SearchProviderName = Name,
IndexNumberEnd = item.IndexNumberEnd
});

return list;
new RemoteSearchResult
{
IndexNumber = item.IndexNumber,
Name = item.Name,
ParentIndexNumber = item.ParentIndexNumber,
PremiereDate = item.PremiereDate,
ProductionYear = item.ProductionYear,
ProviderIds = item.ProviderIds,
SearchProviderName = Name,
IndexNumberEnd = item.IndexNumberEnd
}
};
}

public async Task<MetadataResult<Episode>> GetMetadata(EpisodeInfo info, CancellationToken cancellationToken)
Expand Down Expand Up @@ -137,8 +136,7 @@ public async Task<MetadataResult<Episode>> GetMetadata(EpisodeInfo info, Cancell
{
if (TmdbUtils.IsTrailerType(video))
{
var videoUrl = string.Format(CultureInfo.InvariantCulture, "http://www.youtube.com/watch?v={0}", video.Key);
item.AddTrailerUrl(videoUrl);
item.AddTrailerUrl("https://www.youtube.com/watch?v=" + video.Key);
}
}
}
Expand Down
13 changes: 7 additions & 6 deletions MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbSeasonImageProvider.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -56,16 +56,17 @@ public async Task<IEnumerable<RemoteImageInfo>> GetImages(BaseItem item, Cancell
.GetSeasonAsync(seriesTmdbId, season.IndexNumber.Value, language, TmdbUtils.GetImageLanguagesParam(language), cancellationToken)
.ConfigureAwait(false);

if (seasonResult?.Images?.Posters == null)
var posters = seasonResult?.Images?.Posters;
if (posters == null)
{
return Enumerable.Empty<RemoteImageInfo>();
}

var remoteImages = new List<RemoteImageInfo>();
for (var i = 0; i < seasonResult.Images.Posters.Count; i++)
var remoteImages = new RemoteImageInfo[posters.Count];
for (var i = 0; i < posters.Count; i++)
{
var image = seasonResult.Images.Posters[i];
remoteImages.Add(new RemoteImageInfo
var image = posters[i];
remoteImages[i] = new RemoteImageInfo
{
Url = _tmdbClientManager.GetPosterUrl(image.FilePath),
CommunityRating = image.VoteAverage,
Expand All @@ -76,7 +77,7 @@ public async Task<IEnumerable<RemoteImageInfo>> GetImages(BaseItem item, Cancell
ProviderName = Name,
Type = ImageType.Primary,
RatingType = RatingType.Score
});
};
}

return remoteImages.OrderByLanguageDescending(language);
Expand Down
19 changes: 11 additions & 8 deletions MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbSeriesImageProvider.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,15 @@ public async Task<IEnumerable<RemoteImageInfo>> GetImages(BaseItem item, Cancell
return Enumerable.Empty<RemoteImageInfo>();
}

var remoteImages = new List<RemoteImageInfo>();
var posters = series.Images.Posters;
var backdrops = series.Images.Backdrops;

for (var i = 0; i < series.Images.Posters.Count; i++)
var remoteImages = new RemoteImageInfo[posters.Count + backdrops.Count];

for (var i = 0; i < posters.Count; i++)
{
var poster = series.Images.Posters[i];
remoteImages.Add(new RemoteImageInfo
var poster = posters[i];
remoteImages[i] = new RemoteImageInfo
{
Url = _tmdbClientManager.GetPosterUrl(poster.FilePath),
CommunityRating = poster.VoteAverage,
Expand All @@ -84,13 +87,13 @@ public async Task<IEnumerable<RemoteImageInfo>> GetImages(BaseItem item, Cancell
ProviderName = Name,
Type = ImageType.Primary,
RatingType = RatingType.Score
});
};
}

for (var i = 0; i < series.Images.Backdrops.Count; i++)
for (var i = 0; i < backdrops.Count; i++)
{
var backdrop = series.Images.Backdrops[i];
remoteImages.Add(new RemoteImageInfo
remoteImages[posters.Count + i] = new RemoteImageInfo
{
Url = _tmdbClientManager.GetBackdropUrl(backdrop.FilePath),
CommunityRating = backdrop.VoteAverage,
Expand All @@ -100,7 +103,7 @@ public async Task<IEnumerable<RemoteImageInfo>> GetImages(BaseItem item, Cancell
ProviderName = Name,
Type = ImageType.Backdrop,
RatingType = RatingType.Score
});
};
}

return remoteImages.OrderByLanguageDescending(language);
Expand Down
34 changes: 20 additions & 14 deletions MediaBrowser.Providers/Plugins/Tmdb/TV/TmdbSeriesProvider.cs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,14 +66,15 @@ public async Task<IEnumerable<RemoteSearchResult>> GetSearchResults(SeriesInfo s
.FindByExternalIdAsync(imdbId, FindExternalSource.Imdb, searchInfo.MetadataLanguage, cancellationToken)
.ConfigureAwait(false);

if (findResult?.TvResults != null)
var tvResults = findResult?.TvResults;
if (tvResults != null)
{
var imdbIdResults = new List<RemoteSearchResult>();
for (var i = 0; i < findResult.TvResults.Count; i++)
var imdbIdResults = new RemoteSearchResult[tvResults.Count];
for (var i = 0; i < tvResults.Count; i++)
{
var remoteResult = MapSearchTvToRemoteSearchResult(findResult.TvResults[i]);
var remoteResult = MapSearchTvToRemoteSearchResult(tvResults[i]);
remoteResult.SetProviderId(MetadataProvider.Imdb, imdbId);
imdbIdResults.Add(remoteResult);
imdbIdResults[i] = remoteResult;
}

return imdbIdResults;
Expand All @@ -88,14 +89,15 @@ public async Task<IEnumerable<RemoteSearchResult>> GetSearchResults(SeriesInfo s
.FindByExternalIdAsync(tvdbId, FindExternalSource.TvDb, searchInfo.MetadataLanguage, cancellationToken)
.ConfigureAwait(false);

if (findResult?.TvResults != null)
var tvResults = findResult?.TvResults;
if (tvResults != null)
{
var tvIdResults = new List<RemoteSearchResult>();
for (var i = 0; i < findResult.TvResults.Count; i++)
var tvIdResults = new RemoteSearchResult[tvResults.Count];
for (var i = 0; i < tvResults.Count; i++)
{
var remoteResult = MapSearchTvToRemoteSearchResult(findResult.TvResults[i]);
var remoteResult = MapSearchTvToRemoteSearchResult(tvResults[i]);
remoteResult.SetProviderId(MetadataProvider.Tvdb, tvdbId);
tvIdResults.Add(remoteResult);
tvIdResults[i] = remoteResult;
}

return tvIdResults;
Expand All @@ -105,10 +107,10 @@ public async Task<IEnumerable<RemoteSearchResult>> GetSearchResults(SeriesInfo s
var tvSearchResults = await _tmdbClientManager.SearchSeriesAsync(searchInfo.Name, searchInfo.MetadataLanguage, cancellationToken)
.ConfigureAwait(false);

var remoteResults = new List<RemoteSearchResult>();
var remoteResults = new RemoteSearchResult[tvSearchResults.Count];
for (var i = 0; i < tvSearchResults.Count; i++)
{
remoteResults.Add(MapSearchTvToRemoteSearchResult(tvSearchResults[i]));
remoteResults[i] = MapSearchTvToRemoteSearchResult(tvSearchResults[i]);
}

return remoteResults;
Expand Down Expand Up @@ -236,7 +238,11 @@ public async Task<MetadataResult<Series>> GetMetadata(SeriesInfo info, Cancellat

private Series MapTvShowToSeries(TvShow seriesResult, string preferredCountryCode)
{
var series = new Series {Name = seriesResult.Name, OriginalTitle = seriesResult.OriginalName};
var series = new Series
{
Name = seriesResult.Name,
OriginalTitle = seriesResult.OriginalName
};

series.SetProviderId(MetadataProvider.Tmdb, seriesResult.Id.ToString(CultureInfo.InvariantCulture));

Expand Down Expand Up @@ -322,7 +328,7 @@ private Series MapTvShowToSeries(TvShow seriesResult, string preferredCountryCod
{
if (TmdbUtils.IsTrailerType(video))
{
series.AddTrailerUrl($"http://www.youtube.com/watch?v={video.Key}");
series.AddTrailerUrl("https://www.youtube.com/watch?v=" + video.Key);
}
}
}
Expand Down

0 comments on commit 6def4b0

Please sign in to comment.