-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent null selectedDraft from breaking render #219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See suggestions—I want to make sure undefined indices are handled and can be read cleanly. Thanks for the PR!
Also adds checks for it being greater than `0` where needed.
For some reason, this binding sometimes would have an `undefined` value, which was then set in the steps of the current workflow (possibly due to refresh from an unpopulated compile step).
@kevboh applied suggestions! Also, I found another bug related to this in which steps in a workflow were sometimes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nearly there.
- Use `!draft` instead of `draft == null` - Always include curly braces for `if` statements
fixes #218