Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent null selectedDraft from breaking render #219

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

b-camphart
Copy link
Contributor

fixes #218

Copy link
Owner

@kevboh kevboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See suggestions—I want to make sure undefined indices are handled and can be read cleanly. Thanks for the PR!

src/view/compile/CompileView.svelte Outdated Show resolved Hide resolved
src/view/explorer/SceneList.svelte Outdated Show resolved Hide resolved
src/view/explorer/SceneList.svelte Outdated Show resolved Hide resolved
src/view/explorer/SceneList.svelte Outdated Show resolved Hide resolved
Also adds checks for it being greater than `0` where needed.
For some reason, this binding sometimes would have an `undefined` value, which was then
set in the steps of the current workflow (possibly due to refresh from an unpopulated
compile step).
@b-camphart
Copy link
Contributor Author

@kevboh applied suggestions! Also, I found another bug related to this in which steps in a workflow were sometimes undefined, causing the same issue of the panel being unresponsive. I removed a binding in a svelte component, which I didn't think was necessary, since the component never actually updated it. Seems to have fixed that problem, and the fix doesn't seem to have changed any functionality.

Copy link
Owner

@kevboh kevboh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nearly there.

src/view/explorer/scene-menu-items.ts Outdated Show resolved Hide resolved
src/view/explorer/scene-menu-items.ts Outdated Show resolved Hide resolved
src/view/explorer/scene-menu-items.ts Outdated Show resolved Hide resolved
src/view/explorer/scene-menu-items.ts Outdated Show resolved Hide resolved
src/view/explorer/scene-menu-items.ts Outdated Show resolved Hide resolved
- Use `!draft` instead of `draft == null`
- Always include curly braces for `if` statements
@kevboh kevboh merged commit 8f45706 into kevboh:main Jan 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Invalidating YAML Breaks Longform Panel
2 participants