Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature templates #390

Merged
merged 2 commits into from
Apr 29, 2022
Merged

Feature templates #390

merged 2 commits into from
Apr 29, 2022

Conversation

LukeWood
Copy link
Contributor

No description provided.

@LukeWood
Copy link
Contributor Author

@bhack FYI

bhack
bhack approved these changes Apr 28, 2022
View reviewed changes
Copy link
Contributor

@bhack bhack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is ok. I will eventually restrict this template, using the title/description, to a specific feature subset where mentioning a papers is something plausible (other then more partial/internal feature requests).

@bhack
Copy link
Contributor

bhack commented Apr 28, 2022

This will fix #383 (as it was not connected to this PR).

@LukeWood LukeWood merged commit a84d9ed into master Apr 29, 2022
@LukeWood
Copy link
Contributor Author

Thanks for the review @bhack

@LukeWood LukeWood deleted the feature_templates branch May 18, 2022 22:35
ianstenbit pushed a commit to ianstenbit/keras-cv that referenced this pull request Aug 6, 2022
Feature templates (keras-team#390)
de4b3ba 
* Update feature request template

* Add some issue templates
adhadse pushed a commit to adhadse/keras-cv that referenced this pull request Sep 17, 2022
@LukeWood
Feature templates (keras-team#390)
79a29cc 
* Update feature request template

* Add some issue templates
freedomtan pushed a commit to freedomtan/keras-cv that referenced this pull request Jul 20, 2023
@mattdangerw
Update error message for covert_to_numpy(keras_tensor) (keras-team#390
351dba5 
)

I just realized we already have a nice error for this in
`keras_tensor.py`, we can trigger it directly, and make sure this
returns the same error as `np.array(keras_tensor)` does.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhack bhack bhack approved these changes

@haifeng-jin haifeng-jin Awaiting requested review from haifeng-jin

@mattdangerw mattdangerw Awaiting requested review from mattdangerw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LukeWood @bhack