Use a max line length of 80 universally #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…MaxLineLength � Conflicts: � keras_cv/layers/feature_pyramid.py � keras_cv/layers/object_detection/roi_align.py � keras_cv/layers/object_detection/rpn_label_encoder.py � keras_cv/layers/object_detection_3d/center_net_label_encoder.py � keras_cv/layers/object_detection_3d/heatmap_decoder.py � keras_cv/layers/preprocessing/base_image_augmentation_layer.py � keras_cv/layers/preprocessing/random_channel_shift.py � keras_cv/layers/preprocessing/random_translation.py � keras_cv/layers/preprocessing_3d/base_augmentation_layer_3d.py � keras_cv/layers/regularization/squeeze_excite.py � keras_cv/layers/spatial_pyramid.py � keras_cv/losses/penalty_reduced_focal_loss.py � keras_cv/models/convmixer.py � keras_cv/models/csp_darknet.py � keras_cv/models/efficientnet_lite.py � keras_cv/models/mobilenet_v3.py � keras_cv/models/object_detection/faster_rcnn.py � keras_cv/models/vit.py
…MaxLineLength � Conflicts: � keras_cv/utils/target_gather.py
…MaxLineLength � Conflicts: � keras_cv/models/backbones/resnet_v2/resnet_v2_backbone.py
…MaxLineLength � Conflicts: � keras_cv/layers/preprocessing/mix_up.py
…MaxLineLength � Conflicts: � keras_cv/callbacks/waymo_evaluation_callback.py � keras_cv/layers/preprocessing/base_image_augmentation_layer.py � keras_cv/layers/preprocessing/cut_mix.py � keras_cv/layers/preprocessing/mosaic.py � keras_cv/models/object_detection/retina_net/retina_net_coco_test.py
…MaxLineLength � Conflicts: � keras_cv/metrics/coco/mean_average_precision.py � keras_cv/metrics/coco/numerical_tests/mean_average_precision_test.py � keras_cv/metrics/coco/numerical_tests/recall_correctness_test.py � keras_cv/metrics/coco/recall.py � keras_cv/metrics/coco/utils.py � keras_cv/utils/fill_utils.py
|
Ping @ianstenbit @LukeWood |
|
Hi @ID6109, I have resolved the conflicts with master. Whenever, you have done it, please ping me. |
haifeng-jin
requested changes
Apr 4, 2023
examples/training/object_detection_3d/waymo/serialize_records.py
Outdated
Show resolved
Hide resolved
haifeng-jin
requested changes
Apr 5, 2023
haifeng-jin
requested changes
Apr 5, 2023
keras_cv/models/object_detection/retina_net/retina_net_label_encoder.py
Outdated
Show resolved
Hide resolved
|
Hey @haifeng-jin , thanks for the review! It seems there are loads of corrections required in the PR. I'll get back to you once I mitigate them. I'll also go through the codebase once again to see if any similar changes are necessary. |
haifeng-jin
requested changes
Apr 7, 2023
|
Thanks, @haifeng-jin . I really appreciate you taking the time to review my code. Seems my understanding of how docstrings are interpreted required some much-needed improvement. |
haifeng-jin
approved these changes
Apr 7, 2023
|
/gcbrun |
|
Thanks for the amazing effort @ID6109! |
Closed
ghost
pushed a commit
to y-vectorfield/keras-cv
that referenced
this pull request
Nov 16, 2023
* Enforces line length 80 Part 1 * Enforces line length 80 Part 2 and fixes typos * Enforces line length 80 Part 3 and fixes typos * Enforces line length 80 Part 4 and fixes typos * Enforces line length 80 Part 5 and fixes typos * Minor change * Replaced double spaces with a single space * Merge Conflicts * Minor Changes * Resolves Merge Conflicts * Additional improvements + Changes requested * Merging * Minor improvements --------- Co-authored-by: Your Name <[email protected]> Co-authored-by: Haifeng Jin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #1532 + a LOT of typos (including replacing double spaces after every sentence with a single space).
Do let me know if any changes are necessary. Thanks.
PS: I'll go ahead with #1500 after this gets merged. Might be too big of a PR or else.
Who can review?
@LukeWood @ianstenbit