Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global rename of classes to num_classes #1474

Merged
merged 18 commits into from
Mar 9, 2023

Conversation

ianstenbit
Copy link
Contributor

@ianstenbit ianstenbit commented Mar 9, 2023

Fixes #1473

@ianstenbit
Copy link
Contributor Author

/gcbrun

@ianstenbit
Copy link
Contributor Author

/gcbrun

@ianstenbit ianstenbit marked this pull request as ready for review March 9, 2023 18:07
@ianstenbit
Copy link
Contributor Author

ianstenbit commented Mar 9, 2023

#657 👀 -- we should make sure we have strong consensus before merging this PR, since apparently we've changed our mind's before, and this is only going to get harder / more intrusive for users as time goes on.

I'll make a PR to KerasIO to update this as well (which we can wait to merge until we cut a release here)

@ianstenbit
Copy link
Contributor Author

Corresponding KerasIO change: keras-team/keras-io#1271

@jbischof
Copy link
Contributor

jbischof commented Mar 9, 2023

Amazing @ianstenbit thank you 🚀 🚀 🚀

@ianstenbit ianstenbit merged commit f2869b6 into keras-team:master Mar 9, 2023
@ianstenbit ianstenbit deleted the classes branch March 9, 2023 20:16
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
* Global rename of classes to num_classes

* fix training scripts

* Fix some box keys

* Fix RetinaNet train

* Fix more box keys;

* Fix more box keys

* Fix more box keys

* Fix demo utils

* Manual layer fixes

* Manual losses + metrics fixes

* Fix number of num_ issue

* Manual models + utils fixes

* Formatting

* Minor rcnn fix

* Manual bbox fixes

* Manual misc fixes

* Manual misc fixes

* Fix convmixer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename classes to num_classes throughout KerasCV
3 participants