Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat with black 23.1 to fix CI #1337

Merged
merged 8 commits into from
Feb 2, 2023
Merged

Conversation

ianstenbit
Copy link
Contributor

@LukeWood
Copy link
Contributor

LukeWood commented Feb 1, 2023

Thanks @ianstenbit !!!

@bhack
Copy link
Contributor

bhack commented Feb 2, 2023

If you are interested in the root cause of this is the we don't explicitly control black version:

"black[jupyter]",

So it is hard to recommend to the user a version if the CI could potentially change at every run.

@ianstenbit
Copy link
Contributor Author

If you are interested in the root cause of this is the we don't explicitly control black version:

"black[jupyter]",

So it is hard to recommend to the user a version if the CI could potentially change at every run.

Is there a reason that we should pin a Black version? Afaik changes are generally backwards-compatible so I think we can just recommend that a user use the latest version of Black in general?

@ianstenbit ianstenbit merged commit 5227e52 into keras-team:master Feb 2, 2023
@bhack
Copy link
Contributor

bhack commented Feb 2, 2023

Is there a reason that we should pin a Black version?

Is that we broke the format randomly at every CI run also on unrelated user PR (as it is already happened multiple time in this repo).

I think that it is better to control when we want to upgrade also if we want to always use the last version.

@ianstenbit
Copy link
Contributor Author

Is there a reason that we should pin a Black version?

Is that we broke the format randomly at every CI run also on unrelated user PR (as it is already happened multiple time in this repo).

I think that it is better to control when we want to upgrade also if we want to always use the last version.

Ack that's fine by me. @LukeWood any issues on your end?
@bhack If you want to open a PR I'll approve -- otherwise I'll open one.

@bhack
Copy link
Contributor

bhack commented Feb 2, 2023

@ianstenbit Please, talk internally with the team as we could find a compromise with ~= on the other deps.

I think we will have less reproducibility but we will gain a bit in flexibility (and recurrent PR over setup.py) at the same time lowering the risk of randomly breaking the CI and local dev-envs.

@ianstenbit ianstenbit deleted the format branch May 31, 2023 16:46
ghost pushed a commit to y-vectorfield/keras-cv that referenced this pull request Nov 16, 2023
* Rename GlobalRandomFlipY -> GlobalRandomFlip

* Rename test

* Switch to 3-boolean params for flip_x/y/z

* Reformat with black 23.1'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants