-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reformat with black 23.1 to fix CI #1337
Conversation
Thanks @ianstenbit !!! |
If you are interested in the root cause of this is the we don't explicitly control black version: Line 58 in e62a3fe
So it is hard to recommend to the user a version if the CI could potentially change at every run. |
Is there a reason that we should pin a Black version? Afaik changes are generally backwards-compatible so I think we can just recommend that a user use the latest version of Black in general? |
Is that we broke the format randomly at every CI run also on unrelated user PR (as it is already happened multiple time in this repo). I think that it is better to control when we want to upgrade also if we want to always use the last version. |
Ack that's fine by me. @LukeWood any issues on your end? |
@ianstenbit Please, talk internally with the team as we could find a compromise with I think we will have less reproducibility but we will gain a bit in flexibility (and recurrent PR over |
* Rename GlobalRandomFlipY -> GlobalRandomFlip * Rename test * Switch to 3-boolean params for flip_x/y/z * Reformat with black 23.1'
@LukeWood