Introduce random drop box 3D data augmentation. #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Add wrap_angle_rad helper function.
2. Change rads -> radians 3. Good point. We could add X or Y rotation as future work. For this PR, let's check in Z rotation first.
tanzhenyu
reviewed
Dec 3, 2022
|
|
||
| def __init__(self, label_index=None, max_drop_bounding_boxes=10, **kwargs): | ||
| super().__init__(**kwargs) | ||
| self.auto_vectorize = False |
There was a problem hiding this comment.
nit: maybe we should just make auto_vectorize by default False for the moment.
| label_index: An optional int scalar sets the target object index. | ||
| If label index is set, randomly drop bounding boxes, where box class == label_index. | ||
| If label index is None, randomly drop bounding boxes, where box class > 0. | ||
| max_drop_bounding_boxes: A int scalar sets the maximum number of dropped bounding boxes. |
There was a problem hiding this comment.
a int non negative scalar
Also default what =0 means here
|
|
||
| """ | ||
|
|
||
| def __init__(self, label_index=None, max_drop_bounding_boxes=10, **kwargs): |
There was a problem hiding this comment.
is 10 a good default number, or do we make this argument mandatory?
There was a problem hiding this comment.
Change it to mandatory.
added 2 commits
December 2, 2022 16:39
tanzhenyu
approved these changes
Dec 5, 2022
|
/gcbrun |
ghost
pushed a commit
to y-vectorfield/keras-cv
that referenced
this pull request
Nov 16, 2023
* Add base augmentation layer for 3D preception. * Fix format. * Add copyright. * Minor change. * revert the minor change in the test file. * 1. Add global_z_rotation data augmentation. 2. Add wrap_angle_rad helper function. * Auto format. * 1. Standardize POINT_CLOUDS and BOUNDING_BOXES 2. Change rads -> radians 3. Good point. We could add X or Y rotation as future work. For this PR, let's check in Z rotation first. * Format. * Delete base_augmentation_layer_3d.py * Delete base_augmentation_layer_3d_test.py * Standardize POINT_CLOUDS and BOUNDING_BOXES names. * Change GlobalZRotation to GlobalRandomZRotation * Support rotation along X, Y and Z axes. * format. * Change file name from global_rotation to global_random_rotation. * Add four more global data augmentations for 3d. * format. * Remove unused import. * Fix a typo in GlobalRandomFlippingY. * Support scaling x, y, and z. * Format. * update random scaling. * Modified based on comments. * follow up. * Fix a typo in random_scaling_test.py * Update. * Fix two typos. * Crop object. * Remove tf.print in test. * Fix typos. * test failed when using is_within_box3d + map function * update. * Rename to group_points_by_bounding_boxes. * Update. * Update. * Format. * Format. * Fix a typo. * Update. * fix a typo. * Introducing randomly pasting object data augmentation. * Update. * Update. * update. * Update. * Update. * Update. * Swap background data augmentation. * Update. * Update. * Clean up. * Update. * Update * Random drop box augmentation. * Update. * Update. Co-authored-by: Leng Zhaoqi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes # (issue)
Before submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.