Restructure StableDiffusion namespace and folder hierarchy #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks great! just to confirm, did you run SD weight loading based on this PR? just as a sanity check all the symbol moves are working as expected. |
I ran the tests which do perform weight loading. Since I managed to introduce a bug on accident with my last PR, I'm also going to run my music video generator script before I merge Edit: I've run a few test workflows using SD after this change, and they all are working fine. |
|
/gcbrun |
ghost
pushed a commit
to y-vectorfield/keras-cv
that referenced
this pull request
Nov 16, 2023
…m#1002) * Move StableDiffusion directory * More refactor, add API instability note * Disable SD tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also adds a note to the SD docstring about API instability.