Hashtable fixes #54
Merged
Hashtable fixes #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Fixed put method from O(N) due to condition `hashval not in keys` which requires a full scan to O(1) amortized. 2. Added empty and deleted unique objects tpo be used as sentinels.
1. Added unit tests for adding more than one entry with the same hash. 2. Added unit test to assure `get` halts if key is not found
1. Fixed documentation 2. added __delitem__
Added len() support and testing
…he `put` method to grow the table by a factor of 2 each time the table has more than 2/3 of it full (same as __builtin__ dict)
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously:
HashTablewas:putmethod was ofO(N)complexity due to thishashval not in keysputmethod crashed withNameErrorMain issues addressed:
putwith O(1) complexityResizableHashTablesubclass that grows exponentially in spaceThanks