Fix bug with "variableWidth: true" and and "rtl: true" #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Links we're broken they are now fixed. |
kenwheeler
added a commit
that referenced
this pull request
Nov 19, 2015
Fix bug with "variableWidth: true" and and "rtl: true"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kenwheeler First of, Thanks for an awesome plugin 😄
Bug reproduced: http://jsfiddle.net/pazaricha/qy18dm5k/
Bug fixed: http://jsfiddle.net/pazaricha/7uLwo1hu/
This works both with the following settings:
slidesToShow & slidesToScrollare irrelevant as far as I understand whenvariableWidthis set totrue. (correct me if I am wrong on this)I'd like to hear your comments and also if you'd like me to bump the version number across the files I will be happy to do so.