Templating utilities for JSON data and KV navigation #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Really nice, if test pass it this getting merged! |
| @@ -115,10 +115,14 @@ func (t *TemplateResource) createStageFile() error { | |||
| // Add template functions | |||
| tplFuncMap := make(template.FuncMap) | |||
| tplFuncMap["base"] = path.Base | |||
| tplFuncMap["parent"] = path.Dir | |||
| tplFuncMap["sibling"] = t.GetSibling | |||
There was a problem hiding this comment.
We might rename this later, but for now I think it works.
|
@johnrengelman Yep, I love when we can merge efforts like this. |
Closed
kelseyhightower
added a commit
that referenced
this pull request
Aug 4, 2014
Templating utilities for JSON data and KV navigation
|
Can we also merge this into the 0.5.x branch? |
tomdee
pushed a commit
to tomdee/confd
that referenced
this pull request
Jun 12, 2018
…ed-libcalico-update Automatic update of libcalico-go to e3351395c934cee118999b9d29508e9280fa75ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also includes some integration tests for Consul since they are dependent upon using the JSON parsing functions. (#102)