Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add time frame #1965

Merged
merged 21 commits into from
Sep 26, 2024
Merged

Conversation

rajeshj11
Copy link
Contributor

@rajeshj11 rajeshj11 commented Sep 18, 2024

Closes #1770
/claim #1770

📑 Description

Add time frame

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

demo video:
https://www.loom.com/share/f0f25de12e724e8c97b62d88f25067e5

Copy link

vercel bot commented Sep 18, 2024

@rajeshj11 is attempting to deploy a commit to the KeepHQ Team on Vercel.

A member of the Team first needs to authorize it.

@rajeshj11 rajeshj11 changed the title Feat 1770 add time frame feat: add time frame Sep 18, 2024
@rajeshj11 rajeshj11 marked this pull request as draft September 18, 2024 17:08
@rajeshj11 rajeshj11 marked this pull request as ready for review September 18, 2024 17:53
@rajeshj11
Copy link
Contributor Author

@Matvey-Kuk @talboren please review

@Matvey-Kuk
Copy link
Contributor

Waiting if #1770 (comment) has a PR before reviewing

@rajeshj11
Copy link
Contributor Author

Waiting if #1770 (comment) has a PR before reviewing

#1770 (comment)
@Matvey-Kuk please review

@talboren
Copy link
Member

@rajeshj11 please add a loom/screenshots to the description of the PR so we can see that context of the change

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
keep ⬜️ Ignored (Inspect) Visit Preview Sep 26, 2024 9:24am

@rajeshj11
Copy link
Contributor Author

Copy link

codecov bot commented Sep 23, 2024

Codecov Report

Attention: Patch coverage is 64.28571% with 10 lines in your changes missing coverage. Please review.

Project coverage is 68.32%. Comparing base (0f8ab69) to head (ecc5b41).
Report is 26 commits behind head on main.

Files with missing lines Patch % Lines
keep/api/routes/preset.py 30.76% 9 Missing ⚠️
keep/searchengine/searchengine.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1965      +/-   ##
==========================================
- Coverage   69.40%   68.32%   -1.09%     
==========================================
  Files         145      151       +6     
  Lines       11810    12681     +871     
==========================================
+ Hits         8197     8664     +467     
- Misses       3613     4017     +404     
Flag Coverage Δ
68.32% <64.28%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rajeshj11
Copy link
Contributor Author

@Matvey-Kuk @talboren Could you please review? I have added the demo video too.

@rajeshj11
Copy link
Contributor Author

@Matvey-Kuk I just wanted to check in on this PR. When you have time, I'd appreciate your review and any feedback. Let me know if there's anything that needs clarification or further improvement.

Thanks for your time!

@rajeshj11
Copy link
Contributor Author

@talboren I noticed that my pull request has been inactive for some time. If it's no longer needed or doesn’t meet the requirements, please feel free to close it—I completely understand.

@talboren
Copy link
Member

@rajeshj11 i see that you are waiting for feedback from @Matvey-Kuk, correct?

@rajeshj11
Copy link
Contributor Author

rajeshj11 commented Sep 26, 2024

@rajeshj11 i see that you are waiting for feedback from @Matvey-Kuk, correct?

Yes, if someone could provide an update on when I can expect feedback from @Matvey-Kuk, I would appreciate it. If I have a rough estimate of a few days, I won’t need to follow up multiple times.

@Matvey-Kuk Matvey-Kuk enabled auto-merge (squash) September 26, 2024 09:19
@Matvey-Kuk Matvey-Kuk merged commit afe8c58 into keephq:main Sep 26, 2024
15 of 18 checks passed
@rajeshj11 rajeshj11 deleted the feat-1770-add-time-frame branch September 26, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[➕ Feature]: Timeframe definition for the dashboard
3 participants