Skip to content
This repository has been archived by the owner on Aug 2, 2024. It is now read-only.

RPC - Support for pending state #1434

Merged

Conversation

bidzyyys
Copy link
Contributor

@bidzyyys bidzyyys commented Feb 3, 2024

Closes #1405

@bidzyyys bidzyyys force-pushed the feature/rpc_support_pending_state branch from 0cd8752 to 13f9456 Compare February 9, 2024 08:50
@bidzyyys bidzyyys marked this pull request as ready for review February 9, 2024 08:51
@bidzyyys bidzyyys force-pushed the feature/rpc_support_pending_state branch from 13f9456 to 13f2961 Compare February 9, 2024 10:05
Copy link
Collaborator

@tdelabro tdelabro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need rpc tests.
Where you submit tx but not seal the block, call this RPC, check that returns yours tx.

crates/client/rpc/src/lib.rs Outdated Show resolved Hide resolved
crates/client/rpc/src/lib.rs Outdated Show resolved Hide resolved
crates/client/rpc/src/lib.rs Outdated Show resolved Hide resolved
crates/client/rpc/src/lib.rs Outdated Show resolved Hide resolved
crates/client/rpc/src/lib.rs Outdated Show resolved Hide resolved
@bidzyyys bidzyyys force-pushed the feature/rpc_support_pending_state branch from 13f2961 to d8aefbf Compare February 9, 2024 15:44
Copy link
Collaborator

@apoorvsadana apoorvsadana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job on the refactor! Just added a small comment.

crates/client/rpc/src/lib.rs Show resolved Hide resolved
crates/client/rpc/src/lib.rs Show resolved Hide resolved
@bidzyyys bidzyyys force-pushed the feature/rpc_support_pending_state branch 2 times, most recently from 1d1231e to 8058fcd Compare February 13, 2024 10:01
crates/client/rpc/src/lib.rs Show resolved Hide resolved
crates/client/rpc/src/lib.rs Outdated Show resolved Hide resolved
@bidzyyys bidzyyys force-pushed the feature/rpc_support_pending_state branch 2 times, most recently from 878acef to a3535d1 Compare February 14, 2024 07:29
@bidzyyys bidzyyys force-pushed the feature/rpc_support_pending_state branch from a3535d1 to a689c69 Compare February 14, 2024 10:27
@tdelabro tdelabro merged commit 194cf75 into keep-starknet-strange:main Feb 21, 2024
12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(rpc): Support for pending state
4 participants