This repository has been archived by the owner on Aug 2, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 301
RPC - Support for pending state #1434
Merged
tdelabro
merged 11 commits into
keep-starknet-strange:main
from
bidzyyys:feature/rpc_support_pending_state
Feb 21, 2024
Merged
RPC - Support for pending state #1434
tdelabro
merged 11 commits into
keep-starknet-strange:main
from
bidzyyys:feature/rpc_support_pending_state
Feb 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bidzyyys
force-pushed
the
feature/rpc_support_pending_state
branch
from
February 9, 2024 08:50
0cd8752
to
13f9456
Compare
bidzyyys
force-pushed
the
feature/rpc_support_pending_state
branch
from
February 9, 2024 10:05
13f9456
to
13f2961
Compare
tdelabro
suggested changes
Feb 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need rpc tests.
Where you submit tx but not seal the block, call this RPC, check that returns yours tx.
bidzyyys
force-pushed
the
feature/rpc_support_pending_state
branch
from
February 9, 2024 15:44
13f2961
to
d8aefbf
Compare
antiyro
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing job on the refactor! Just added a small comment.
bidzyyys
force-pushed
the
feature/rpc_support_pending_state
branch
2 times, most recently
from
February 13, 2024 10:01
1d1231e
to
8058fcd
Compare
tdelabro
suggested changes
Feb 13, 2024
bidzyyys
force-pushed
the
feature/rpc_support_pending_state
branch
2 times, most recently
from
February 14, 2024 07:29
878acef
to
a3535d1
Compare
bidzyyys
force-pushed
the
feature/rpc_support_pending_state
branch
from
February 14, 2024 10:27
a3535d1
to
a689c69
Compare
tdelabro
approved these changes
Feb 21, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1405