🐛 Fix/non markdown text area not clean (argilla-io#3775)

If the record has text area with non markdown, sometimes when the user wants to clear the record that text area doesn't clear --------- Co-authored-by: keithCuniah <[email protected]>
kcentric · Sep 15, 2023 · 02b2d61 · 02b2d61
1 parent 670e658
commit 02b2d61
Show file tree

Hide file tree

Showing 10 changed files with 8 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -58,6 +58,7 @@ These are the section headers that we use:
 
 ### Fixed
 
+- Fixed `remove user modification in text component on clear answers` ([#3775](https://github.com/argilla-io/argilla/pull/3775))
 - Fixed `Highlight raw text field in dataset feedback task` ([#3731](https://github.com/argilla-io/argilla/pull/3731))
 - Fixed `Field title too long` ([#3734](https://github.com/argilla-io/argilla/pull/3734))
 - Fixed error messages when deleting a `DatasetForTextClassification` ([#3652](https://github.com/argilla-io/argilla/pull/3652))

diff --git a/frontend/components/commons/forms/questions-form/useQuestionsFormViewModel.ts b/frontend/components/commons/forms/questions-form/useQuestionsFormViewModel.ts
@@ -23,6 +23,7 @@ export const useQuestionFormViewModel = () => {
 
   const discard = (record: Record) => {
     debounceForAutoSave.stop();
+    beforeUnload.destroy();
 
     queue.enqueue(() => {
       return discardUseCase.execute(record);
@@ -31,6 +32,7 @@ export const useQuestionFormViewModel = () => {
 
   const submit = (record: Record) => {
     debounceForAutoSave.stop();
+    beforeUnload.destroy();
 
     queue.enqueue(() => {
       return submitUseCase.execute(record);
@@ -39,6 +41,7 @@ export const useQuestionFormViewModel = () => {
 
   const clear = (record: Record) => {
     debounceForAutoSave.stop();
+    beforeUnload.destroy();
 
     queue.enqueue(() => {
       return clearUseCase.execute(record);

diff --git a/frontend/components/feedback-task/ContentEditableFeedbackTask.vue b/frontend/components/feedback-task/ContentEditableFeedbackTask.vue
@@ -101,7 +101,9 @@ export default {
     reset() {
       this.currentValue = this.value;
       this.sanitizedCurrentValue = " ";
-      this.sanitizedCurrentValue = this.currentValue;
+      this.$nextTick(() => {
+        this.sanitizedCurrentValue = this.currentValue;
+      });
     },
     exitEditionMode() {
       this.$refs.text.blur();

diff --git a/...tion-mode-page/__screenshots__/chromium/Annotate-page-clear-all-questions-1.png b/...tion-mode-page/__screenshots__/chromium/Annotate-page-clear-all-questions-1.png
diff --git a/...tion-mode-page/__screenshots__/chromium/Annotate-page-clear-all-questions-3.png b/...tion-mode-page/__screenshots__/chromium/Annotate-page-clear-all-questions-3.png
diff --git a/...ation-mode-page/__screenshots__/firefox/Annotate-page-clear-all-questions-1.png b/...ation-mode-page/__screenshots__/firefox/Annotate-page-clear-all-questions-1.png
diff --git a/...ation-mode-page/__screenshots__/firefox/Annotate-page-clear-all-questions-3.png b/...ation-mode-page/__screenshots__/firefox/Annotate-page-clear-all-questions-3.png
diff --git a/...tation-mode-page/__screenshots__/webkit/Annotate-page-clear-all-questions-1.png b/...tation-mode-page/__screenshots__/webkit/Annotate-page-clear-all-questions-1.png
diff --git a/...tation-mode-page/__screenshots__/webkit/Annotate-page-clear-all-questions-3.png b/...tation-mode-page/__screenshots__/webkit/Annotate-page-clear-all-questions-3.png
diff --git a/frontend/e2e/annotation-mode-page/annotation-mode.page.spec.ts b/frontend/e2e/annotation-mode-page/annotation-mode.page.spec.ts
@@ -124,17 +124,9 @@ test.describe("Annotate page", () => {
   test("clear all questions", async ({ page }) => {
     await goToAnnotationPage(page);
 
-    await page.getByRole("button", { name: "Clear" }).click();
-
     await expect(page).toHaveScreenshot();
 
-    await page
-      .getByText("Review Rating", { exact: true })
-      .scrollIntoViewIfNeeded();
-
-    await expect(page).toHaveScreenshot();
-
-    await page.getByText("Ranking", { exact: true }).scrollIntoViewIfNeeded();
+    await page.getByRole("button", { name: "Clear" }).click();
 
     await expect(page).toHaveScreenshot();
   });