Merge pull request #151 from Wybrenb/animation-delay

Animation delay
kartik-v · Jan 30, 2017 · 7d2afae · 7d2afae
2 parents d703b19 + 69b4772
commit 7d2afae
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 6 deletions.
diff --git a/Editable.php b/Editable.php
@@ -390,6 +390,11 @@ class Editable extends InputWidget
      * @var boolean whether to select all text in the input when editable is opened.
      */
     public $selectAllOnEdit = true;
+
+    /**
+     * @var integer editable animation delay (in micro-seconds). Defaults to `200`.
+     */
+    public $animationDelay = 200;
 
     /**
      * @var boolean whether to HTML encode the output via javascript after editable update. Defaults to `true`. Note that
@@ -537,6 +542,7 @@ public function registerAssets()
             'selectAllOnEdit' => $this->selectAllOnEdit,
             'encodeOutput' => $this->encodeOutput,
             'validationDelay' => $this->validationDelay,
+            'animationDelay' => $this->animationDelay
         ];
         $this->registerPlugin('editable', 'jQuery("#' . $this->containerOptions['id'] . '")');
         if (!empty($this->pjaxContainerId)) {

diff --git a/assets/js/editable.js b/assets/js/editable.js
@@ -107,16 +107,16 @@
                     }
                 },
                 closeClick: function () {
-                    self.toggle(false);
+                    self.toggle(false, self.animationDelay);
                 },
                 targetClick: function () {
                     var status;
                     if (self.asPopover) {
-                        self.toggle(true);
+                        self.toggle(true, self.animationDelay);
                         return;
                     }
                     status = !$inline.is(':visible');
-                    self.toggle(status);
+                    self.toggle(status, self.animationDelay);
                 },
                 resetClick: function () {
                     if (self.raise($el, 'editableReset')) {
@@ -207,12 +207,12 @@
                                         $parent2.find('.help-block').remove();
                                         $parent2.removeClass('has-error');
                                         $message.html('');
-                                        self.toggle(false);
+                                        self.toggle(false, self.animationDelay);
                                         self.$value.html(out);
                                     } else {
                                         $parent.removeClass('has-error');
                                         $message.html('');
-                                        self.toggle(false);
+                                        self.toggle(false, self.animationDelay);
                                         self.$value.html(out);
                                         if (objActiveForm) {
                                             $form.yiiActiveForm('destroy');
@@ -355,7 +355,8 @@
         selectAllOnEdit: true,
         asPopover: true,
         encodeOutput: true,
-        validationDelay: 500
+        validationDelay: 500,
+        animationDelay: 200
     };
 
     $.fn.editable.Constructor = Editable;