-
Notifications
You must be signed in to change notification settings - Fork 247
Comparing changes
Open a pull request
base repository: karma-runner/karma-coverage
base: v2.1.0
head repository: karma-runner/karma-coverage
compare: v2.1.1
- 8 commits
- 5 files changed
- 4 contributors
Commits on Dec 1, 2021
-
chore(deps): bump y18n from 4.0.0 to 4.0.3
Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.3. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/y18n-v4.0.3/CHANGELOG.md) - [Commits](yargs/y18n@v4.0.0...y18n-v4.0.3) --- updated-dependencies: - dependency-name: y18n dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6b4bc7f - Browse repository at this point
Copy the full SHA 6b4bc7fView commit details -
chore(deps): bump hosted-git-info from 2.8.8 to 2.8.9
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 8d2064a - Browse repository at this point
Copy the full SHA 8d2064aView commit details -
chore(deps): bump ini from 1.3.5 to 1.3.8
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) --- updated-dependencies: - dependency-name: ini dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 0069b99 - Browse repository at this point
Copy the full SHA 0069b99View commit details -
chore(deps): bump handlebars from 4.7.3 to 4.7.7
Bumps [handlebars](https://github.com/wycats/handlebars.js) from 4.7.3 to 4.7.7. - [Release notes](https://github.com/wycats/handlebars.js/releases) - [Changelog](https://github.com/handlebars-lang/handlebars.js/blob/master/release-notes.md) - [Commits](handlebars-lang/handlebars.js@v4.7.3...v4.7.7) Signed-off-by: dependabot[bot] <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 6484d9a - Browse repository at this point
Copy the full SHA 6484d9aView commit details -
chore(deps): update indirect deps
Jonathan Ginsburg committedDec 1, 2021 Configuration menu - View commit details
-
Copy full SHA for 4adb3ef - Browse repository at this point
Copy the full SHA 4adb3efView commit details
Commits on Feb 5, 2022
-
fix: race condition between the Karma shutdown and coverage writing
The creation of parent directories is asynchronous process, which was not properly awaited, which resulted in the coverage reports not being written to the disk sometimes as Karma process has exited before the reporter completed the writing of the coverage report. Also update the test case to use async implementation of the corresponding stub to prevent regressions in the future. Remove manual calls for `done` parameter in tests as it is handled by the stub now. Fixes #434
Configuration menu - View commit details
-
Copy full SHA for 44b31eb - Browse repository at this point
Copy the full SHA 44b31ebView commit details -
fix: handle unexpected error when generating code coverage
The issue surfaced itself after d970028. The EEXIST error from concurrent attempts to create the same directory were previously silently swallowed, but started to show up once the call was properly synchronized. The EEXIST will now result in `promiseComplete` being rejected and reported as `unhandledRejection` because it is awaited in the `onExit` callback. The unhandled rejection is then picked up by `karma` [here](https://github.com/karma-runner/karma/blob/c985155a4eac95c525e1217e98d4013ac5f53305/lib/server.js#L395) triggering [the close logic](https://github.com/karma-runner/karma/blob/c985155a4eac95c525e1217e98d4013ac5f53305/lib/server.js#L392) which (among other things) will trigger `onExit` callback causing an infinite loop. The local fix is to handle the rejected promise directly and report failure to karma by passing a non-zero exit code.
Configuration menu - View commit details
-
Copy full SHA for bca2c69 - Browse repository at this point
Copy the full SHA bca2c69View commit details -
chore(release): 2.1.1 [skip ci]
## [2.1.1](v2.1.0...v2.1.1) (2022-02-05) ### Bug Fixes * handle unexpected error when generating code coverage ([bca2c69](bca2c69)), closes [/github.com/karma-runner/karma/blob/c985155a4eac95c525e1217e98d4013ac5f53305/lib/server.js#L392](https://github.com//github.com/karma-runner/karma/blob/c985155a4eac95c525e1217e98d4013ac5f53305/lib/server.js/issues/L392) * race condition between the Karma shutdown and coverage writing ([44b31eb](44b31eb)), closes [#434](#434)
Configuration menu - View commit details
-
Copy full SHA for 2675374 - Browse repository at this point
Copy the full SHA 2675374View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.1.0...v2.1.1