Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: karma-runner/karma-coverage
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.1.0
Choose a base ref
...
head repository: karma-runner/karma-coverage
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.1.1
Choose a head ref
  • 8 commits
  • 5 files changed
  • 4 contributors

Commits on Dec 1, 2021

  1. chore(deps): bump y18n from 4.0.0 to 4.0.3

    Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.3.
    - [Release notes](https://github.com/yargs/y18n/releases)
    - [Changelog](https://github.com/yargs/y18n/blob/y18n-v4.0.3/CHANGELOG.md)
    - [Commits](yargs/y18n@v4.0.0...y18n-v4.0.3)
    
    ---
    updated-dependencies:
    - dependency-name: y18n
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and Jonathan Ginsburg committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    6b4bc7f View commit details
    Browse the repository at this point in the history
  2. chore(deps): bump hosted-git-info from 2.8.8 to 2.8.9

    dependabot[bot] authored and Jonathan Ginsburg committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    8d2064a View commit details
    Browse the repository at this point in the history
  3. chore(deps): bump ini from 1.3.5 to 1.3.8

    Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8.
    - [Release notes](https://github.com/isaacs/ini/releases)
    - [Commits](npm/ini@v1.3.5...v1.3.8)
    
    ---
    updated-dependencies:
    - dependency-name: ini
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <[email protected]>
    dependabot[bot] authored and Jonathan Ginsburg committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    0069b99 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6484d9a View commit details
    Browse the repository at this point in the history
  5. chore(deps): update indirect deps

    Jonathan Ginsburg committed Dec 1, 2021
    Configuration menu
    Copy the full SHA
    4adb3ef View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2022

  1. fix: race condition between the Karma shutdown and coverage writing

    The creation of parent directories is asynchronous process, which was not properly awaited, which resulted in the coverage reports not being written to the disk sometimes as Karma process has exited before the reporter completed the writing of the coverage report.
    
    Also update the test case to use async implementation of the corresponding stub to prevent regressions in the future. Remove manual calls for `done` parameter in tests as it is handled by the stub now.
    
    Fixes #434
    devoto13 authored and Jonathan Ginsburg committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    44b31eb View commit details
    Browse the repository at this point in the history
  2. fix: handle unexpected error when generating code coverage

    The issue surfaced itself after d970028. The EEXIST error from concurrent attempts to create the same directory were previously silently swallowed, but started to show up once the call was properly synchronized.
    
    The EEXIST will now result in `promiseComplete` being rejected and reported as `unhandledRejection` because it is awaited in the `onExit` callback. The unhandled rejection is then picked up by `karma` [here](https://github.com/karma-runner/karma/blob/c985155a4eac95c525e1217e98d4013ac5f53305/lib/server.js#L395) triggering [the close logic](https://github.com/karma-runner/karma/blob/c985155a4eac95c525e1217e98d4013ac5f53305/lib/server.js#L392) which (among other things) will trigger `onExit` callback causing an infinite loop.
    
    The local fix is to handle the rejected promise directly and report failure to karma by passing a non-zero exit code.
    devoto13 authored and Jonathan Ginsburg committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    bca2c69 View commit details
    Browse the repository at this point in the history
  3. chore(release): 2.1.1 [skip ci]

    ## [2.1.1](v2.1.0...v2.1.1) (2022-02-05)
    
    ### Bug Fixes
    
    * handle unexpected error when generating code coverage ([bca2c69](bca2c69)), closes [/github.com/karma-runner/karma/blob/c985155a4eac95c525e1217e98d4013ac5f53305/lib/server.js#L392](https://github.com//github.com/karma-runner/karma/blob/c985155a4eac95c525e1217e98d4013ac5f53305/lib/server.js/issues/L392)
    * race condition between the Karma shutdown and coverage writing ([44b31eb](44b31eb)), closes [#434](#434)
    semantic-release-bot committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    2675374 View commit details
    Browse the repository at this point in the history
Loading