-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#70: Add some basic linter functionality #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uberspot
force-pushed
the
lint
branch
2 times, most recently
from
January 15, 2019 19:04
58fba1b
to
e220921
Compare
gburiola
reviewed
Jan 16, 2019
gburiola
reviewed
Jan 16, 2019
uberspot
force-pushed
the
lint
branch
2 times, most recently
from
January 17, 2019 11:40
fb86323
to
e7a9ece
Compare
adrianchifor
approved these changes
Jan 17, 2019
ramaro
reviewed
Jan 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial work for #70:
Adding checks for
Also minor consolidation for the "list_all_paths" logic which was duplicated in 3-4 places and a better message for
kapitan compile
when it fails to load inventories in malformed yaml files.