Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: omegaconf inventory by @MatteoVoges #1173

Merged
merged 7 commits into from
Aug 17, 2024
Merged

feat: omegaconf inventory by @MatteoVoges #1173

merged 7 commits into from
Aug 17, 2024

Conversation

ademariag
Copy link
Contributor

@ademariag ademariag commented Apr 24, 2024 •
edited
Loading

Proposed Changes

  • Implements OmegaConf based Inventory by @MatteoVoges (@kapicorp/nexenio-team)
  • Speeds up inventory loading and compilation (2x faster)

Instructions

Activate the new inventory

 global:
   compose-target-name: true
   inventory-backend: omegaconf

or use the command line flag --inventory-backend=omegaconf

Migrate your inventory to the new setup

Migrate your inventory
 ./kapitan compile --migrate

Docs and Tests

  • Tests added
  • Updated documentation

@ademariag ademariag marked this pull request as ready for review April 24, 2024 07:59
@ademariag ademariag changed the title Test/omegaconf feat: omegaconf inventory by @MatteoVoges Apr 24, 2024
This was referenced Apr 24, 2024
Closed
Closed
@ademariag ademariag mentioned this pull request May 1, 2024
Merged
2 tasks
ademariag added a commit that referenced this pull request May 1, 2024
@ademariag
Merge pull request #1175 from kapicorp/move-to-pytest
0443a54 
Incremental changes from OmegaConf work #1173
@ademariag ademariag force-pushed the test/omegaconf branch 6 times, most recently from a439925 to 41dc759 Compare May 15, 2024 14:56
simu
simu reviewed May 27, 2024
View reviewed changes
kapitan/inventory/inventory.py Show resolved Hide resolved
kapitan/inventory/inventory.py Show resolved Hide resolved
kapitan/inventory/inventory.py Show resolved Hide resolved
kapitan/inventory/inventory.py Show resolved Hide resolved
kapitan/targets.py Outdated Show resolved Hide resolved
kapitan/cached.py Outdated Show resolved Hide resolved
kapitan/cached.py Outdated Show resolved Hide resolved
kapitan/cached.py Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
simu
simu reviewed May 28, 2024
View reviewed changes
kapitan/targets.py Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Stale label Jul 28, 2024
@github-actions github-actions bot removed the Stale label Aug 14, 2024
@ademariag ademariag merged commit 936623c into master Aug 17, 2024
17 checks passed
@ademariag ademariag deleted the test/omegaconf branch August 17, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simu simu simu left review comments

@gbamaxw gbamaxw gbamaxw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ademariag @simu @gbamaxw