Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement GetEnteringArcs. #6

Merged
merged 1 commit into from
Apr 24, 2020
Merged

Conversation

csukuangfj
Copy link
Collaborator

// CHECK(CheckProperties(fsa, KTopSorted));

is currently disabled.

Should we use glog or implement our own glog like functions ?

@danpovey
Copy link
Collaborator

Fantastic!
I'm OK to include glog, depending what the others think...

@danpovey danpovey merged commit f75a615 into k2-fsa:master Apr 24, 2020
@csukuangfj
Copy link
Collaborator Author

@qindazhu @galv
what do you think about glog?

@csukuangfj csukuangfj deleted the fangjun-fsa-util branch April 24, 2020 23:36
@qindazhu
Copy link
Collaborator

I'm ok with glog.

@galv
Copy link
Contributor

galv commented Apr 25, 2020

glog-like functions are annoying to implement. We did that for kaldi, as people here are aware. Implementing KALDI_ERROR macro is actually pretty complicated because it requires throwing an exception in a destructor.

Also, glog, uses poor-ly named space macros like LOG, ERROR, etc.,so you may as well just use glog, in case another library also depends on it.

So I think glog is fine.

@csukuangfj
Copy link
Collaborator Author

@galv @qindazhu
thanks, I'll include glog in later commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants