-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds asynchronous load of the extension #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Nikita. Looks good.
One question: why did you add the imaging library? Was it brought in as a dependency of the Shell.15 package?
yes, it happens to be one of Microsoft.VisualStudio.Shell.15.0 dependency package. |
Thanks. |
Shell.15 is only available from VS2017 and above. |
yeah, it seems like that. Do you want me to generate new guid for this extension in this pr? and I suppose we need to update current: in .vsixmanifest to indicate that this version is only available from VS2017+. Should I do this in current pr? |
Tough call. Many users have already installed it for VS2019. If we use the same Guid, those users will get an automatic upgrade, which is probably the best thing for us to do for them. Although, users on VS2015 will get a rude shock when they upgrade, as it will simply stop writing for them. I think we should keep the same Guid for VS2109 and create a new Guid for the legacy one. I'll sort that out. Let's make the installation target for this one VS2017+. |
sounds reasonable. |
# Conflicts: # source.extension.vsixmanifest
I have released a new version for VS2017/VS2019 with a new GUID. |
This pull request adds an asynchronous load of the extension so it could work properly in VS2019 without throwing notification. In order to make async load possible, Microsoft.VisualStudio.Shell.15 package has been added and the project .csproj was updated to target 4.7.2