avoid deprecation warnings in test_api teardown #301
Conversation
replaces nose-style teardown with a fixture
|
@minrk hmm, any idea why all the tests are failing everywhere? |
|
Test failures in main for 3 weeks: https://github.com/jupyterhub/nbgitpuller/actions/workflows/test.yml?query=branch%3Amain |
|
I wasn't able to reproduce it locally, and noticed there's been a git release (2.40). It's a change in behavior between git 2.39.2 and 2.40 which apparently changed what's a resolvable conflict. I can't seem to find the changelog for git itself to track it down. |
|
#302 fixes the failure with git 2.40 |
There was a problem hiding this comment.
Since you have run tests locally successfully, and we know they are failing pending #302, I'll go for a merge here already as I think this looks great and just influences the test suite anyhow.
|
Congrats on your first merged pull request in this project! 🎉 |
replaces nose-style teardown with a fixture
tests are unchanged, but diff is large because it's mostly dedented.