Fix test_exception_branch_exists

[a3626a]

Recently, I have ported a portion of nbgitpuller into Ruby On Rails compatible ruby version. Meanwhile, I have found that 'test_exception_branch_exists' doesn't test anything. Actually puller.gp.branch_exists("wrong") was not throwing any errors, and assert type(e) == ValueError was not called at all.

I refered test_exception_resolve_default_branch and test_git_lock, and introduced exception_raised variable and puller.gp.git_url = "" assignment.

[welcome]

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.

You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[yuvipanda]

Ah, thanks for looking into this!

Can you rework this to use https://docs.pytest.org/en/7.1.x/how-to/assert.html#assertions-about-expected-exceptions instead? That's the expected way to test for expected exceptions in pytest I think.

[a3626a]

Ah, thanks for looking into this!

Can you rework this to use https://docs.pytest.org/en/7.1.x/how-to/assert.html#assertions-about-expected-exceptions instead? That's the expected way to test for expected exceptions in pytest I think.

Of course, that is great. It is done.

[yuvipanda]

Thanks @a3626a. Looks like the test failures may be related?

[a3626a]

@yuvipanda

Thanks @a3626a. Looks like the test failures may be related?

It is really done!

[welcome]

Congrats on your first merged pull request in this project! 🎉

Thank you for contributing, we are very proud of you! ❤️