Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update contributing guide to use git-pull #202

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Conversation

fperez
Copy link
Contributor

@fperez fperez commented Aug 26, 2021

The contribution guide still lists git-sync, which if I understand correctly, is a legacy alias for git-pull. This updates the docs.

The contribution guide still lists `git-sync`, which if I understand correctly, is a legacy alias for `git-pull`. This updates the docs.
@welcome
Copy link

welcome bot commented Aug 26, 2021

Thanks for submitting your first pull request! You are awesome! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please make sure you followed the pull request template, as this will help us review your contribution more quickly.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also a intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@consideRatio
Copy link
Member

consideRatio commented Aug 26, 2021

From this code, I conclude you are correct that it is git-pull that is the non-deprecated URL!

def load_jupyter_server_extension(nbapp):
    web_app = nbapp.web_app
    base_url = url_path_join(web_app.settings['base_url'], 'git-pull')
    handlers = [
        (url_path_join(base_url, 'api'), SyncHandler),
        (base_url, UIHandler),
        (url_path_join(web_app.settings['base_url'], 'git-sync'), LegacyGitSyncRedirectHandler),
        (url_path_join(web_app.settings['base_url'], 'interact'), LegacyInteractRedirectHandler),
        (
            url_path_join(base_url, 'static', '(.*)'),
            StaticFileHandler,
            {'path': os.path.join(os.path.dirname(__file__), 'static')}
        )
    ]
    web_app.settings['nbapp'] = nbapp
    web_app.add_handlers('.*', handlers)

Thanks @fperez ❤️ 🎉!

@consideRatio consideRatio merged commit 58e61f6 into main Aug 26, 2021
@welcome
Copy link

welcome bot commented Aug 26, 2021

Congrats on your first merged pull request in this project! 🎉
congrats
Thank you for contributing, we are very proud of you! ❤️

@fperez
Copy link
Contributor Author

fperez commented Aug 27, 2021

Thanks for the fast turnaround @consideRatio!

@minrk minrk deleted the fperez-patch-1 branch April 4, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants