Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using the new Comm Python package #3533

Merged
merged 6 commits into from
Mar 21, 2023
Merged

Using the new Comm Python package #3533

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
48a3d54
Move comm package
martinRenou Aug 1, 2022
e78d151
Fix wrongly written test
martinRenou Feb 16, 2023
4e5dd22
Fix Python 3.7 test
martinRenou Feb 16, 2023
2a31b38
Code suggestions
martinRenou Mar 17, 2023
74ee640
Add comment
martinRenou Mar 17, 2023
ad8ec43
Any
martinRenou Mar 17, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add comment
  • Loading branch information
@martinRenou
martinRenou committed Mar 21, 2023
commit 74ee6404430fb4e0ecf9312df8374109480c7894
1 change: 1 addition & 0 deletions python/ipywidgets/ipywidgets/widgets/widget_output.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ def __exit__(self, etype, evalue, tb):
ip.showtraceback((etype, evalue, tb), tb_offset=0)
elif (self.comm is not None and
getattr(self.comm, "kernel", None) is not None and
# Check if it's ipykernel
getattr(self.comm.kernel, "send_response", None) is not None):
martinRenou marked this conversation as resolved.
Show resolved Hide resolved
kernel = self.comm.kernel
kernel.send_response(kernel.iopub_socket,
Expand Down