Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.1.0 Release]: Integrate major upstream changes into ipydatagrid #239

Merged
merged 20 commits into from
Jul 17, 2021
Merged

[1.1.0 Release]: Integrate major upstream changes into ipydatagrid #239

merged 20 commits into from
Jul 17, 2021

Conversation

ibdafna
Copy link
Member

@ibdafna ibdafna commented May 31, 2021

This PR integrates major changes made over the past year in upstream lumino, into ipydatagrid:

  • Merged cells data model (both column and row headers)
  • Text wrapping
  • Text eliding

@ibdafna ibdafna marked this pull request as draft May 31, 2021 21:57
@ibdafna
Copy link
Member Author

ibdafna commented May 31, 2021

Some issues with HeaderRenderer filter/sort icons not rendering on every column. Seems like config.width values for "HR" are always 128 pixels - needs investigation.

image

@ibdafna
Copy link
Member Author

ibdafna commented Jun 1, 2021

UPDATE: the wrong config.width value is a bug upstream. I'll need to look into the logic again.

@ibdafna
Copy link
Member Author

ibdafna commented Jun 22, 2021

PR to fix the issue mentioned above, upstream:

jupyterlab/lumino#197

@ibdafna ibdafna changed the title Integrate major upstream changes into ipydatagrid [1.1.0 Release]: Integrate major upstream changes into ipydatagrid Jun 22, 2021
gaborbernat
gaborbernat previously approved these changes Jul 16, 2021
View reviewed changes
@ibdafna ibdafna marked this pull request as ready for review July 16, 2021 22:41
@ibdafna ibdafna requested a review from gaborbernat July 16, 2021 22:51
@ibdafna
Run linter
00e5984 
Signed-off-by: Itay Dafna <[email protected]>
@ibdafna ibdafna merged commit 44724c4 into jupyter-widgets:main Jul 17, 2021
@ibdafna ibdafna deleted the service_pack branch July 17, 2021 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaborbernat gaborbernat gaborbernat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ibdafna @gaborbernat