Set private the lists fEmpty, fFull and remove unnecessary boxing on ListTest #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change from protected to private fEmpty and fFull Remove unnecesary boxing on fFull.remove()
kcooney
requested changes
Nov 21, 2016
| @@ -11,8 +11,9 @@ | |||
| * A sample test case, testing {@link java.util.ArrayList}. | |||
| */ | |||
| public class ListTest extends TestCase { | |||
| protected List<Integer> fEmpty; | |||
| protected List<Integer> fFull; | |||
| private List<Integer> fEmpty; | |||
There was a problem hiding this comment.
While you are changing this, could you please rename "fEmpty" to "empty" or "emptyList"?
There was a problem hiding this comment.
Just to be more clear about the samples, on my way to do the changes
| protected List<Integer> fFull; | ||
| private List<Integer> fEmpty; | ||
|
|
||
| private List<Integer> fFull; | ||
|
|
||
| public static void main(String[] args) { |
There was a problem hiding this comment.
While you are changing this file, please remove the main method.
…me fFull to fullList Requested changes
|
@kcooney Ready Requested Changes
Checklist
|
kcooney
approved these changes
Nov 21, 2016
| } | ||
|
|
||
| public void testElementAt() { | ||
| int i = fFull.get(0); | ||
| int i = fullList.get(0); | ||
| assertTrue(i == 1); |
There was a problem hiding this comment.
Do you think we should use assertEquals() (with as useful message) instead of assertTrue() so you'll get a useful stack trace if this fails? Future users might look at this file as an example of how to write a good JUnit test.
There was a problem hiding this comment.
Yes is more readable 👍
| protected List<Integer> fEmpty; | ||
| protected List<Integer> fFull; | ||
| private List<Integer> emptyList; | ||
|
|
| protected List<Integer> fFull; | ||
| private List<Integer> emptyList; | ||
|
|
||
| private List<Integer> fullList; |
There was a problem hiding this comment.
style-nit: remove extra blank line after this declaration.
|
@kcooney Ready 👍 Requested Changes
Checklist
|
kcooney
approved these changes
Nov 21, 2016
marcphilipp
approved these changes
Nov 22, 2016
sebasjm
pushed a commit
to sebasjm/junit4
that referenced
this pull request
Mar 11, 2018
* Set private to fEmpty, fFull and remove unnecesary boxing on ListTest * Change from protected to private fEmpty and fFull * Remove unnecesary boxing on fFull.remove() * Remove main method from ListTest, rename fEmpty to emptyList and rename fFull to fullList
aristotle0x01
pushed a commit
to aristotle0x01/junit4
that referenced
this pull request
Jun 27, 2022
* Set private to fEmpty, fFull and remove unnecesary boxing on ListTest * Change from protected to private fEmpty and fFull * Remove unnecesary boxing on fFull.remove() * Remove main method from ListTest, rename fEmpty to emptyList and rename fFull to fullList
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
fEmptyandfFulllists, because there is no need to keep accessible from the package and subclassfFull.remove()because Java creates an Integer object fromiand adds to the objectfFullRequested Changes
fEmptytoemptyListfFulltofullListassertTrue()forassertEquals()ontestElementAt()methodChecklist
mvn verifyReferences:
Controlling Access to Members of a Class
Autoboxing and Unboxing