Optimize string format #1346
Merged
Optimize string format #1346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In format strings, it is generally preferable better to use %n, which will produce the platform-specific line separator.
|
I don't have a strong opinion about this one. @junit-team/junit-lambda What do you think? |
|
Oops, I mistook this issue for an opentest4j one (now there is one over there, too: ota4j-team/opentest4j#24). @junit-team/junit-committers What do you think about this one? |
|
The commit message is a bit weird (this isn't an optimizationn) but we can fix that when we merge the commit if we use |
sebasjm
pushed a commit
to sebasjm/junit4
that referenced
this pull request
Mar 11, 2018
In format strings, it is generally preferable better to use %n, which will produce the platform-specific line separator.
aristotle0x01
pushed a commit
to aristotle0x01/junit4
that referenced
this pull request
Jun 27, 2022
In format strings, it is generally preferable better to use %n, which will produce the platform-specific line separator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In format strings, it is generally preferable better to use %n, which will produce the platform-specific line separator.