CI: Try to fix workflow definition #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `services` key should be part of a job. See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idservices.
julik
approved these changes
Oct 28, 2023
Now that the port is exposed on localhost, this should work.
Merged
franzliedke
commented
Nov 2, 2023
| @@ -2,7 +2,7 @@ | |||
| class Idempo::ActiveRecordBackend | |||
| def self.create_table(via_migration) | |||
| via_migration.create_table 'idempo_responses', charset: 'utf8mb4', collation: 'utf8mb4_unicode_ci' do |t| | |||
| t.string :idempotent_request_key, index: true, unique: true, null: false | |||
| t.string :idempotent_request_key, index: {unique: true}, null: false | |||
There was a problem hiding this comment.
@julik This change should be mentioned in release notes. Users will have to manually re-create a UNIQUE index. (Not sure why, but this wrong syntax raised an exception in the tests, while it was simply ignored in production.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
serviceskey should be part of a job.See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idservices.