Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently constructing ComponentArrays on the GPU with for example
ComponentArray(a=CUDA.ones(2,3), b=CUDA.ones(4,5))
fails with an error.This fails because constructing the ComponentArray causes the creation of an array of arrays, which is not possible on the GPU. This happens in the
pushcat!
call at line 179 in componentarray.jl:ComponentArrays.jl/src/componentarray.jl
Lines 178 to 182 in a7d6f7d
This pull request fixes the issue by constructing the ComponentArray on the CPU and moving it back to the GPU afterwards.
Fixes #158. Needed for SciML/NeuralPDE.jl#594.