localstorage remove_item #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation for remove_item makes sense. And if you had problems with delete then lets just go with remove_item... If it causes problems, we can just do a patch release. Compilation is failing on wasm, though... so that needs to be fixed. |
Merged
|
@v-kat I provided a separate PR for upgrading bevy itself. i had no chance to debug the other fix you are providing here, but this way we unblock users who need bevy 0.14 support |
v-kat
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't tested it much so it's still a draft but the wasm local storage delete never worked properly for me so I was going to switch to https://docs.rs/web-sys/latest/web_sys/struct.Storage.html#method.remove_item I'm still waiting for some other libraries to update to do more extensive testing.