Skip to content

Commit

Permalink
cleanup: method is identical to its super method
Browse files Browse the repository at this point in the history
GitOrigin-RevId: 350ea63057fc436a3bcebed964228c43db8d5923
  • Loading branch information
cdracm authored and intellij-monorepo-bot committed Jan 27, 2022
1 parent b50194d commit 965f6c7
Show file tree
Hide file tree
Showing 136 changed files with 8 additions and 831 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -116,14 +116,6 @@ public boolean isValid() {
return true;
}

@Override
public void selectNotify() {
}

@Override
public void deselectNotify() {
}

@Override
public void addPropertyChangeListener(@NotNull PropertyChangeListener listener) {
myDispatcher.addListener(listener);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,6 @@ public static Sdk getMostRecentSuitableSdk(final WizardContext context) {
return null;
}

@Override
@NotNull
public WizardContext getWizardContext() {
return myWizardContext;
}

@Override
protected String getDimensionServiceKey() {
return "NewModule_or_Project.wizard";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,4 @@ private static void moveComments(@NotNull PsiElement oldParameter,
}
}
}

@Override
public boolean startInWriteAction() {
return true;
}
}
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Copyright 2000-2021 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
package com.intellij.codeInspection.dataFlow.types;

import com.intellij.psi.PsiPrimitiveType;
import org.jetbrains.annotations.NotNull;

public final class DfBooleanConstantType extends DfConstantType<Boolean> implements DfBooleanType {
Expand All @@ -22,12 +21,6 @@ public DfType join(@NotNull DfType other) {
return join(other);
}

@NotNull
@Override
public PsiPrimitiveType getPsiType() {
return DfBooleanType.super.getPsiType();
}

@NotNull
@Override
public DfType tryNegate() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
package com.intellij.codeInspection.dataFlow.types;

import com.intellij.codeInspection.dataFlow.value.RelationType;
import com.intellij.psi.PsiPrimitiveType;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

Expand Down Expand Up @@ -55,12 +54,6 @@ private DfType join(@NotNull DfType other, boolean exact) {
return DfDoubleRangeType.fromRelation(relationType, value, value);
}

@NotNull
@Override
public PsiPrimitiveType getPsiType() {
return DfDoubleType.super.getPsiType();
}

@NotNull
@Override
public DfType tryNegate() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
package com.intellij.codeInspection.dataFlow.types;

import com.intellij.codeInspection.dataFlow.value.RelationType;
import com.intellij.psi.PsiPrimitiveType;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

Expand Down Expand Up @@ -55,12 +54,6 @@ private DfType join(@NotNull DfType other, boolean exact) {
return DfFloatRangeType.fromRelation(relationType, value, value);
}

@NotNull
@Override
public PsiPrimitiveType getPsiType() {
return DfFloatType.super.getPsiType();
}

@NotNull
@Override
public DfType tryNegate() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

import com.intellij.codeInspection.dataFlow.rangeSet.LongRangeSet;
import com.intellij.codeInspection.dataFlow.value.RelationType;
import com.intellij.psi.PsiPrimitiveType;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

Expand All @@ -17,12 +16,6 @@ public class DfIntConstantType extends DfConstantType<Integer> implements DfIntT
myWideRange = wideRange;
}

@NotNull
@Override
public PsiPrimitiveType getPsiType() {
return DfIntType.super.getPsiType();
}

@Override
public boolean isSuperType(@NotNull DfType other) {
return DfIntType.super.isSuperType(other);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

import com.intellij.codeInspection.dataFlow.rangeSet.LongRangeSet;
import com.intellij.codeInspection.dataFlow.value.RelationType;
import com.intellij.psi.PsiPrimitiveType;
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

Expand Down Expand Up @@ -33,12 +32,6 @@ public boolean isSuperType(@NotNull DfType other) {
return DfLongType.super.meet(other);
}

@NotNull
@Override
public PsiPrimitiveType getPsiType() {
return DfLongType.super.getPsiType();
}

@NotNull
@Override
public LongRangeSet getRange() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,4 @@ private static boolean isDuplicate(PsiJavaCodeReferenceElement element,
final PsiManager manager = aClass.getManager();
return !manager.areElementsEquivalent(otherElement, element) && manager.areElementsEquivalent(otherElement.resolve(), aClass);
}

@Override
public boolean startInWriteAction() {
return true;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -299,9 +299,4 @@ protected JComponent getAdditionalActionSettings(Project project, BaseAnalysisAc
myUi.getCheckBox().setSelected(PropertiesComponent.getInstance().getBoolean(ANNOTATE_LOCAL_VARIABLES));
return myUi.getPanel();
}

@Override
protected void canceled() {
super.canceled();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ protected PsiElement getNavigationElement(@NotNull PsiClass createdElement) {
return createdElement.getLBrace();
}

@SuppressWarnings("RedundantMethodOverride")
@Override
protected void postProcess(@NotNull PsiClass createdElement, String templateName, Map<String, String> customProperties) {
// This override is necessary for plugin compatibility
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
import com.intellij.lang.Language;
import com.intellij.openapi.project.DumbService;
import com.intellij.openapi.util.NlsSafe;
import com.intellij.openapi.util.registry.Registry;
import com.intellij.psi.*;
import com.intellij.psi.impl.source.PsiClassReferenceType;
import com.intellij.psi.util.PsiExpressionTrimRenderer;
Expand All @@ -15,8 +14,6 @@
import org.jetbrains.annotations.NotNull;
import org.jetbrains.annotations.Nullable;

import javax.swing.Icon;

import static com.intellij.openapi.util.text.StringUtil.*;
import static com.intellij.psi.PsiNameHelper.getShortClassName;

Expand Down Expand Up @@ -50,12 +47,6 @@ else if (e instanceof PsiAnonymousClass) {
return suffix != null ? description + suffix : description;
}

@Nullable
@Override
public Icon getElementIcon(@NotNull PsiElement element) {
return null;
}

@Nullable
@Override
public String getElementTooltip(@NotNull PsiElement e) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,15 +42,6 @@ public PsiManager getManager() {
return getParent().getManager();
}

@Override
public PsiFile getContainingFile() {
PsiElement parent = getParent();
if (parent == null) {
throw new PsiInvalidElementAccessException(this);
}
return parent.getContainingFile();
}

@Override
public final boolean isWritable() {
return false;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,11 +34,6 @@ public final class EclipseCompilerTool extends JavaCompilingTool {
return JavaCompilers.ECLIPSE_EMBEDDED_ID;
}

@Override
public boolean isCompilerTreeAPISupported() {
return false;
}

@Override
public @NotNull String getDescription() {
String version = myVersion;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,6 @@ public FileFilter createFileFilter() {
return file -> !excludes.isExcluded(file) && myFilterForExcludedPatterns.accept(file);
}

@Override
public boolean isGenerated() {
return false;
}

@Override
public String toString() {
return "ResourceRootDescriptor{target='" + myTarget + '\'' + ", root=" + myRoot + '}';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -286,11 +286,6 @@ public void save(final DataOutput out) {
void kindToStream(final PrintStream stream) {
stream.println("MetaMethodUsage:");
}

@Override
public void toStream(DependencyContext context, PrintStream stream) {
super.toStream(context, stream);
}
}

public static class ImportStaticMemberUsage extends FMUsage {
Expand All @@ -312,11 +307,6 @@ public void save(final DataOutput out) {
void kindToStream(final PrintStream stream) {
stream.println("ImportStaticMemberUsage:");
}

@Override
public void toStream(DependencyContext context, PrintStream stream) {
super.toStream(context, stream);
}
}

public static class ClassUsage extends Usage {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,6 @@ public boolean isTests() {
return myTargetType.isTests();
}

@Override
public boolean isCompiledBeforeModuleLevelBuilders() {
return false;
}

@Override
public Collection<BuildTarget<?>> computeDependencies(BuildTargetRegistry targetRegistry, TargetOutputIndex outputIndex) {
JpsJavaDependenciesEnumeratorImpl enumerator = (JpsJavaDependenciesEnumeratorImpl)JpsJavaExtensionService.dependencies(myModule).compileOnly();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -280,12 +280,6 @@ public void generateInstructions(JpsProductionModuleSourcePackagingElement eleme
generateModuleSourceInstructions(productionSources, instructionCreator, element);
}
}

@Override
public Collection<? extends BuildTarget<?>> getDependencies(@NotNull JpsProductionModuleSourcePackagingElement element,
TargetOutputIndex outputIndex) {
return Collections.emptyList();
}
}

private static class ModuleTestOutputElementBuilder extends LayoutElementBuilderService<JpsTestModuleOutputPackagingElement> {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,6 @@ else if (outputType == ProcessOutputTypes.STDERR) {
stdErrParser.append(event.getText());
}
}

@Override
public void processTerminated(@NotNull ProcessEvent event) {
super.processTerminated(event);
}
});
handler.startNotify();
handler.waitFor();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,10 @@
*/
package org.jetbrains.jps.model.java;

import org.jetbrains.annotations.NotNull;
import org.jetbrains.jps.model.JpsDummyElement;
import org.jetbrains.jps.model.JpsElementFactory;
import org.jetbrains.jps.model.ex.JpsElementTypeWithDummyProperties;
import org.jetbrains.jps.model.library.JpsLibraryType;

public class JpsJavaLibraryType extends JpsElementTypeWithDummyProperties implements JpsLibraryType<JpsDummyElement> {
public static final JpsJavaLibraryType INSTANCE = new JpsJavaLibraryType();

@NotNull
@Override
public JpsDummyElement createDefaultProperties() {
return JpsElementFactory.getInstance().createDummyElement();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,10 @@
*/
package org.jetbrains.jps.model.java;

import org.jetbrains.annotations.NotNull;
import org.jetbrains.jps.model.JpsDummyElement;
import org.jetbrains.jps.model.JpsElementFactory;
import org.jetbrains.jps.model.ex.JpsElementTypeWithDummyProperties;
import org.jetbrains.jps.model.module.JpsModuleType;

public class JpsJavaModuleType extends JpsElementTypeWithDummyProperties implements JpsModuleType<JpsDummyElement> {
public static final JpsJavaModuleType INSTANCE = new JpsJavaModuleType();

@NotNull
@Override
public JpsDummyElement createDefaultProperties() {
return JpsElementFactory.getInstance().createDummyElement();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,6 @@ public String getUnknownTypeId() {
return myUnknownTypeId;
}

@Override
public boolean isForTests() {
return false;
}

@NotNull
@Override
public UnknownSourceRootTypeProperties<?> createDefaultProperties() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,6 @@ public class JdkVersionDetectorImpl extends JdkVersionDetector {
private static class VersionOutputReader extends BaseOutputReader {
private static final BaseOutputReader.Options OPTIONS = new BaseOutputReader.Options() {
@Override public SleepingPolicy policy() { return SleepingPolicy.BLOCKING; }
@Override public boolean splitToLines() { return true; }
@Override public boolean sendIncompleteLines() { return false; }
@Override public boolean withSeparators() { return false; }
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,11 +95,6 @@ private static Pair<PsiElement, PsiElement> expandCommentsInRange(@NotNull Pair<
return Pair.create(upper, lower);
}

@Override
public void beforeMove(@NotNull Editor editor, @NotNull MoveInfo info, boolean down) {

}

@Override
public void afterMove(@NotNull Editor editor, @NotNull PsiFile file, @NotNull MoveInfo info, boolean down) {
int diff = (info.toMove.endLine - info.toMove.startLine) - (info.toMove2.endLine - info.toMove2.startLine);
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
// Copyright 2000-2018 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license that can be found in the LICENSE file.
package com.jetbrains.jsonSchema.impl.inspections;

import com.intellij.codeHighlighting.HighlightDisplayLevel;
import com.intellij.codeInspection.LocalInspectionTool;
import com.intellij.codeInspection.LocalInspectionToolSession;
import com.intellij.codeInspection.ProblemsHolder;
Expand All @@ -21,11 +20,6 @@
import java.util.Collection;

public abstract class JsonSchemaBasedInspectionBase extends LocalInspectionTool {
@NotNull
@Override
public HighlightDisplayLevel getDefaultLevel() {
return HighlightDisplayLevel.WARNING;
}

@NotNull
@Override
Expand Down
Loading

0 comments on commit 965f6c7

Please sign in to comment.