test for plugin.xml having <description> tag; provide description for…

… some GitOrigin-RevId: 19c99952bf69a63af76710cd1621880910d948cd
jjwwhmm · Oct 19, 2021 · 37154ef · 37154ef
1 parent ea1830f
commit 37154ef
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/images/resources/META-INF/plugin.xml b/images/resources/META-INF/plugin.xml
@@ -2,7 +2,8 @@
   <vendor>JetBrains</vendor>
   <name>Images</name>
   <id>com.intellij.platform.images</id>
-
+  <description>Adds support for image file type preview, SVG file type contents language</description>
+
   <depends optional="true" config-file="images-copyright-plugin.xml">com.intellij.copyright</depends>
 
   <extensionPoints>

diff --git a/platform/build-scripts/groovy/org/jetbrains/intellij/build/impl/PluginsCollector.groovy b/platform/build-scripts/groovy/org/jetbrains/intellij/build/impl/PluginsCollector.groovy
@@ -168,7 +168,8 @@ final class PluginsCollector {
         incompatiblePlugins += pluginId.getTextTrim()
       }
 
-      def pluginDescriptor = new PluginDescriptor(id, declaredModules, requiredDependencies, incompatiblePlugins, optionalDependencies, pluginLayout)
+      String description = xml.getChildTextTrim("description")
+      def pluginDescriptor = new PluginDescriptor(id, description, declaredModules, requiredDependencies, incompatiblePlugins, optionalDependencies, pluginLayout)
       pluginDescriptors[id] = pluginDescriptor
       for (module in declaredModules) {
         pluginDescriptors[module] = pluginDescriptor
@@ -179,16 +180,22 @@ final class PluginsCollector {
 
   static final class PluginDescriptor {
     final String id
+    final String description
     final Set<String> declaredModules
     final Set<String> requiredDependencies
     final Set<String> incompatiblePlugins
     final List<Pair<String, String>> optionalDependencies
     final PluginLayout pluginLayout
 
-    PluginDescriptor(String id, Set<String> declaredModules,
-                     Set<String> requiredDependencies, Set<String> incompatiblePlugins,
-                     List<Pair<String, String>> optionalDependencies, PluginLayout pluginLayout) {
+    PluginDescriptor(String id,
+                     String description,
+                     Set<String> declaredModules,
+                     Set<String> requiredDependencies,
+                     Set<String> incompatiblePlugins,
+                     List<Pair<String, String>> optionalDependencies,
+                     PluginLayout pluginLayout) {
       this.id = id
+      this.description = description
       this.declaredModules = declaredModules
       this.requiredDependencies = requiredDependencies
       this.incompatiblePlugins = incompatiblePlugins

diff --git a/plugins/ui-designer/resources/META-INF/plugin.xml b/plugins/ui-designer/resources/META-INF/plugin.xml
@@ -3,6 +3,7 @@
   <id>com.intellij.uiDesigner</id>
   <category>Swing</category>
   <vendor>JetBrains</vendor>
+  <description>Allows to design Swing UI graphically, supports code generation/instrumentation, preview, widgets library and UI-related code inspections</description>
   <resource-bundle>messages.UIDesignerBundle</resource-bundle>
   <depends>com.intellij.java-i18n</depends>
   <depends>com.intellij.properties</depends>