Adding Response + cleaning up classically optimize #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
skushnir123
commented
Feb 7, 2024
skushnir123
commented
- Added Response class, QHD.optimzie now returns a Response object
- Cleaned up classically optimize
- Edited notebooks to all comply with new code structure
jiaqileng
reviewed
Feb 7, 2024
src/qhdopt/qhd.py
Outdated
| if samples is None: | ||
| samples = np.random.rand(self.shots, self.dimension) | ||
| def classically_optimize(self, shots=100, solver="TNC", verbose=0): | ||
| self.baseline_setup(shots, solver) |
There was a problem hiding this comment.
In baseline_setup (and baseline backend exec), the samples are initialized randomly on the discretized space (i.e., the mesh grid point). But I assume classically_optimize(...) should also be able to handle user-specified initial guesses. Or do we move this feature to some other functions?
jiaqileng
reviewed
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.