Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show field_creator instead of Drupal author #77

Merged
merged 4 commits into from
Nov 16, 2021
Merged

Show field_creator instead of Drupal author #77

merged 4 commits into from
Nov 16, 2021

Conversation

jabrah
Copy link
Collaborator

@jabrah jabrah commented Nov 11, 2021 •
edited
Loading

Related jhu-idc/iDC-general#432

Visible changes

  • Center Mirador's loading spinner
  • No longer shows Drupal author (since it's just admin every time)
  • Show field_creator - truncated HTML returned by Drupal

image

Other changes

  • Fix a pesky JS error from Drupal's quick-edit module
  • Stop code splitting in Mirador so that we can enable Drupal's JS aggregation setting

@jabrah jabrah merged commit 0c32304 into main Nov 16, 2021
@jabrah jabrah deleted the search-show-creator branch November 16, 2021 21:12
@jaredgalanis jaredgalanis mentioned this pull request Nov 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredgalanis jaredgalanis jaredgalanis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jabrah @jaredgalanis