Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve checkerror syntax #1280

Merged
merged 9 commits into from
Nov 18, 2021
Merged

Improve checkerror syntax #1280

merged 9 commits into from
Nov 18, 2021

Conversation

sverdlov93
Copy link
Contributor

@sverdlov93 sverdlov93 commented Nov 11, 2021 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.
  • I used gofmt for formatting the code before submitting the pull request.

Added errorutils.checkerrorf to replace errorutils.checkerror(errors.New(fmt.printf( "format" , a...)))

Depends on core PR
Depends on client PR

@sverdlov93
improve checkerror syntax
a6e9028 
Signed-off-by: sverdlov93 <[email protected]>
@sverdlov93 sverdlov93 requested review from eyalbe4 and removed request for talarian1 November 11, 2021 18:33
@sverdlov93 sverdlov93 added the safe to test Approve running integration tests on a pull request label Nov 18, 2021
@sverdlov93 sverdlov93 merged commit 2137bf7 into jfrog:dev Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees
No one assigned
Labels
safe to test Approve running integration tests on a pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sverdlov93 @eyalbe4