Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The common group of shuffles is: shuffle in groups, then shuffle groups.
Example is avx2 shuffle 128 byte lanes and then intermix them somehow.
There is a question: what to do first: do you shuffle big groups first or in big groups first.
Techincally: big groups first is strictly more powerful.
However, can lead to better 0ing.
It's not an obvious thing at all and I suspect we will come back to this one again.
Now I implemented "in groups then groups" to solve avx2 slide (partially.
for asimd we used to have purely
vextq_u16
based solution.Now this will prefer
shift_n
when that's avaliable, becasue no constants (horray - the system works).For neon it's not enabled, because there is a bug in level computation:
emulation
should always return 0 but sometimes it returns 1. Which messes withneon
, double.